Re: [PATCH 2/5] commit-graph: add missing forward declaration

On 6/21/2018 6:39 PM, Jonathan Tan wrote: Both this and the previous patch look good to me; you seem to have better (stricter) checking for missing includes/forward declarations, am I missing a compile option? (I have DEVELOPER=1 in config.mak) Thanks. No I don't - I discovered that these were m

Re: [PATCH 2/5] commit-graph: add missing forward declaration

> Both this and the previous patch look good to me; > you seem to have better (stricter) checking for > missing includes/forward declarations, am I missing > a compile option? (I have DEVELOPER=1 in config.mak) Thanks. No I don't - I discovered that these were missing as I was including these head

Re: [PATCH 2/5] commit-graph: add missing forward declaration

Hi Jonathan, On Thu, Jun 21, 2018 at 2:29 PM Jonathan Tan wrote: > > Signed-off-by: Jonathan Tan Both this and the previous patch look good to me; you seem to have better (stricter) checking for missing includes/forward declarations, am I missing a compile option? (I have DEVELOPER=1 in config.m

[PATCH 2/5] commit-graph: add missing forward declaration

Signed-off-by: Jonathan Tan --- commit-graph.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/commit-graph.h b/commit-graph.h index 260a468e73..7004dfdca9 100644 --- a/commit-graph.h +++ b/commit-graph.h @@ -3,6 +3,8 @@ #include "git-compat-util.h" +struct commit; + char *get_commit_