Re: [PATCH 2/4] t0021: put $TEST_ROOT in $PATH

2016-11-06 Thread Lars Schneider
> On 02 Nov 2016, at 19:18, Jeff King wrote: > > We create a rot13.sh script in the trash directory, but need > to call it by its full path when we have moved our cwd to > another directory. Let's just put $TEST_ROOT in our $PATH so > that the script is always found. > > This is a minor conveni

Re: [PATCH 2/4] t0021: put $TEST_ROOT in $PATH

2016-11-03 Thread Johannes Sixt
Am 03.11.2016 um 21:44 schrieb Jeff King: On Thu, Nov 03, 2016 at 09:40:01PM +0100, Johannes Sixt wrote: We have to use $PWD instead of $(pwd) because on Windows... Thanks. I have to admit I remain confused about which one to use at any given invocation No worries. It *is* complex, and I don

Re: [PATCH 2/4] t0021: put $TEST_ROOT in $PATH

2016-11-03 Thread Johannes Sixt
Am 02.11.2016 um 19:18 schrieb Jeff King: > We create a rot13.sh script in the trash directory, but need > to call it by its full path when we have moved our cwd to > another directory. Let's just put $TEST_ROOT in our $PATH so > that the script is always found. > > This is a minor convenience for

Re: [PATCH 2/4] t0021: put $TEST_ROOT in $PATH

2016-11-03 Thread Jeff King
On Thu, Nov 03, 2016 at 09:40:01PM +0100, Johannes Sixt wrote: > > TEST_ROOT="$(pwd)" > > +PATH=$TEST_ROOT:$PATH > > This causes problems on Windows. We need the following squashed in. > > 8< > [PATCH] squash! t0021: put $TEST_ROOT in $PATH > > We have to use $PWD instead of $(pwd) b

[PATCH 2/4] t0021: put $TEST_ROOT in $PATH

2016-11-02 Thread Jeff King
We create a rot13.sh script in the trash directory, but need to call it by its full path when we have moved our cwd to another directory. Let's just put $TEST_ROOT in our $PATH so that the script is always found. This is a minor convenience for rot13.sh, but will be a major one when we switch rot1