Re: [PATCH 2/4] submodule: unset core.worktree if no working tree is present

2018-12-28 Thread Junio C Hamano
Stefan Beller writes: > 2018-09-07). The revert was needed as the nearby commit e98317508c > (submodule: ensure core.worktree is set after update, 2018-06-18) is > faulty and at the time of 7e25437d35 (Merge branch > 'sb/submodule-core-worktree', 2018-07-18) we could not revert the faulty > commi

[PATCH 2/4] submodule: unset core.worktree if no working tree is present

2018-12-14 Thread Stefan Beller
When a submodules work tree is removed, we should unset its core.worktree setting as the worktree is no longer present. This is not just in line with the conceptual view of submodules, but it fixes an inconvenience for looking at submodules that are not checked out: git clone --recurse-submodu

Re: [PATCH 2/4] submodule: unset core.worktree if no working tree is present

2018-12-07 Thread Junio C Hamano
Stefan Beller writes: > This reintroduces 4fa4f90ccd (submodule: unset core.worktree if no working > tree is present, 2018-06-12), which was reverted as part of f178c13fda > (Revert "Merge branch 'sb/submodule-core-worktree'", 2018-09-07). > > 4fa4f90ccd was reverted as its followup commit was fa

[PATCH 2/4] submodule: unset core.worktree if no working tree is present

2018-12-07 Thread Stefan Beller
This reintroduces 4fa4f90ccd (submodule: unset core.worktree if no working tree is present, 2018-06-12), which was reverted as part of f178c13fda (Revert "Merge branch 'sb/submodule-core-worktree'", 2018-09-07). 4fa4f90ccd was reverted as its followup commit was faulty, but without the accompanyin