Re: [PATCH 2/4] mark_parents_uninteresting(): drop missing object check

2018-05-12 Thread Junio C Hamano
Jeff King writes: > 2. It "lies" about the commit by setting the parsed flag, > even though we didn't load any useful data into the > struct. This shouldn't matter for the UNINTERESTING > case, but we may later clear our flags and do another > traversal in the same process.

[PATCH 2/4] mark_parents_uninteresting(): drop missing object check

2018-05-11 Thread Jeff King
We allow UNINTERESTING objects in a traversal to be unavailable. As part of this, mark_parents_uninteresting() checks whether we have a particular uninteresting parent; if not, we will mark it as "parsed" so that later code skips it. This code is redundant and even a little bit harmful, so let's d