Re: [PATCH 2/3] t7406: avoid having git commands upstream of a pipe

2018-08-06 Thread Elijah Newren
On Mon, Aug 6, 2018 at 8:48 AM SZEDER Gábor wrote: > > @@ -922,7 +928,7 @@ test_expect_success 'submodule update clone shallow > > submodule' ' > > sed -e "s#url = ../#url = file://$pwd/#" <.gitmodules > > >.gitmodules.tmp && > > mv -f .gitmodules.tmp .gitmodules && >

Re: [PATCH 2/3] t7406: avoid having git commands upstream of a pipe

2018-08-06 Thread SZEDER Gábor
> When a git command is on the left side of a pipe, the pipe will swallow > its exit status, preventing us from detecting failures in said commands. > Restructure the tests to put the output in a temporary file to avoid > this problem. > > Signed-off-by: Elijah Newren > --- > t/t7406-submodul

[PATCH 2/3] t7406: avoid having git commands upstream of a pipe

2018-08-06 Thread Elijah Newren
When a git command is on the left side of a pipe, the pipe will swallow its exit status, preventing us from detecting failures in said commands. Restructure the tests to put the output in a temporary file to avoid this problem. Signed-off-by: Elijah Newren --- t/t7406-submodule-update.sh | 24 ++