Re: [PATCH 2/3] run-command: Be more informative about what failed

2013-01-31 Thread Junio C Hamano
Jeff King writes: > But it is not much code, and sometimes it is surprising what information > can be helpful when debugging, so like you, I am not opposed, just > doubtful. Yes, exactly my feeling. Perhaps I should just amend the 'stdin' and friends away without asking Stephen to reroll. In t

Re: [PATCH 2/3] run-command: Be more informative about what failed

2013-01-31 Thread Jeff King
On Thu, Jan 31, 2013 at 08:24:21AM -0800, Junio C Hamano wrote: > Stephen Boyd writes: > > > While debugging an error with verify_signed_buffer() the error > > messages from run-command weren't very useful: > > > > error: cannot create pipe for gpg: Too many open files > > error: could not run

Re: [PATCH 2/3] run-command: Be more informative about what failed

2013-01-31 Thread Stephen Boyd
On 01/31/13 08:24, Junio C Hamano wrote: > Stephen Boyd writes: > >> While debugging an error with verify_signed_buffer() the error >> messages from run-command weren't very useful: >> >> error: cannot create pipe for gpg: Too many open files >> error: could not run gpg. >> >> because they didn'

Re: [PATCH 2/3] run-command: Be more informative about what failed

2013-01-31 Thread Junio C Hamano
Stephen Boyd writes: > While debugging an error with verify_signed_buffer() the error > messages from run-command weren't very useful: > > error: cannot create pipe for gpg: Too many open files > error: could not run gpg. > > because they didn't indicate *which* pipe couldn't be created. For t

[PATCH 2/3] run-command: Be more informative about what failed

2013-01-30 Thread Stephen Boyd
While debugging an error with verify_signed_buffer() the error messages from run-command weren't very useful: error: cannot create pipe for gpg: Too many open files error: could not run gpg. because they didn't indicate *which* pipe couldn't be created. Print which pipe failed to be created in