Re: [PATCH 2/3] gitk: write only changed configuration variables

2014-09-11 Thread Junio C Hamano
Max Kirillov writes: > On Thu, Sep 11, 2014 at 10:19:56AM -0700, Junio C Hamano wrote: >> Max Kirillov writes: >> >>> If a variable is changed in a concurrent gitk or manually it is >>> preserved unless it has changed in this instance >> >> It would have been easier to understand why this is a

Re: [PATCH 2/3] gitk: write only changed configuration variables

2014-09-11 Thread Max Kirillov
On Thu, Sep 11, 2014 at 10:19:56AM -0700, Junio C Hamano wrote: > Max Kirillov writes: > >> If a variable is changed in a concurrent gitk or manually it is >> preserved unless it has changed in this instance > > It would have been easier to understand why this is a desirable > change if you stat

Re: [PATCH 2/3] gitk: write only changed configuration variables

2014-09-11 Thread Junio C Hamano
Max Kirillov writes: > If a variable is changed in a concurrent gitk or manually it is > preserved unless it has changed in this instance It would have been easier to understand why this is a desirable change if you stated what problem you are trying to solve before that sentence. "If I do X, Y

[PATCH 2/3] gitk: write only changed configuration variables

2014-09-10 Thread Max Kirillov
If a variable is changed in a concurrent gitk or manually it is preserved unless it has changed in this instance This change does not affect geometry and views save; geometry does not need it, and views need special merging, which treats each view separately rather that fully replace the shole lis