Re: [PATCH 2/3] diff: introduce diff.submodule configuration variable

2012-11-13 Thread Junio C Hamano
Ramkumar Ramachandra writes: > Jeff King wrote: >> On Sun, Nov 11, 2012 at 10:29:05PM +0530, Ramkumar Ramachandra wrote: >>> @@ -223,6 +238,15 @@ int git_diff_basic_config(const char *var, const char >>> *value, void *cb) >>> return 0; >>> } >>> >>> + if (!strcmp(var, "di

Re: [PATCH 2/3] diff: introduce diff.submodule configuration variable

2012-11-13 Thread Ramkumar Ramachandra
Jeff King wrote: > On Sun, Nov 11, 2012 at 10:29:05PM +0530, Ramkumar Ramachandra wrote: >> @@ -223,6 +238,15 @@ int git_diff_basic_config(const char *var, const char >> *value, void *cb) >> return 0; >> } >> >> + if (!strcmp(var, "diff.submodule")) { > > Shouldn't this be

Re: [PATCH 2/3] diff: introduce diff.submodule configuration variable

2012-11-12 Thread Jeff King
On Sun, Nov 11, 2012 at 10:29:05PM +0530, Ramkumar Ramachandra wrote: > +static int parse_submodule_params(struct diff_options *options, const char > *value, > + struct strbuf *errmsg) > +{ > + if (!strcmp(value, "log")) > + DIFF_OPT_SET(options, SUBMOD

[PATCH 2/3] diff: introduce diff.submodule configuration variable

2012-11-11 Thread Ramkumar Ramachandra
Introduce a diff.submodule configuration variable corresponding to the '--submodule' command-line option of 'git diff'. Signed-off-by: Ramkumar Ramachandra --- Documentation/diff-config.txt|7 ++ Documentation/diff-options.txt |3 +- cache.h |1 + d

Re: [PATCH 2/3] diff: introduce diff.submodule configuration variable

2012-11-11 Thread Jeff King
On Sun, Nov 11, 2012 at 08:20:27PM +0530, Ramkumar Ramachandra wrote: > >> diff --git a/builtin/diff.c b/builtin/diff.c > >> index 9650be2..6d00311 100644 > >> --- a/builtin/diff.c > >> +++ b/builtin/diff.c > >> @@ -297,6 +297,10 @@ int cmd_diff(int argc, const char **argv, const char > >> *prefi

Re: [PATCH 2/3] diff: introduce diff.submodule configuration variable

2012-11-11 Thread Ramkumar Ramachandra
Jeff King wrote: > On Thu, Nov 01, 2012 at 04:13:49PM +0530, Ramkumar Ramachandra wrote: > >> diff --git a/builtin/diff.c b/builtin/diff.c >> index 9650be2..6d00311 100644 >> --- a/builtin/diff.c >> +++ b/builtin/diff.c >> @@ -297,6 +297,10 @@ int cmd_diff(int argc, const char **argv, const char >

Re: [PATCH 2/3] diff: introduce diff.submodule configuration variable

2012-11-08 Thread Jeff King
On Thu, Nov 01, 2012 at 04:13:49PM +0530, Ramkumar Ramachandra wrote: > diff --git a/builtin/diff.c b/builtin/diff.c > index 9650be2..6d00311 100644 > --- a/builtin/diff.c > +++ b/builtin/diff.c > @@ -297,6 +297,10 @@ int cmd_diff(int argc, const char **argv, const char > *prefix) > DIFF_OP

[PATCH 2/3] diff: introduce diff.submodule configuration variable

2012-11-01 Thread Ramkumar Ramachandra
Introduce a diff.submodule configuration variable corresponding to the '--submodule' command-line option of 'git diff'. Signed-off-by: Ramkumar Ramachandra --- Documentation/diff-config.txt|7 +++ Documentation/diff-options.txt |3 ++- builtin/diff.c |4 ++