Re: [PATCH 2/3] archive: implement protocol v2 archive command

2018-09-14 Thread Jonathan Nieder
Junio C Hamano wrote: > Jonathan Nieder writes: >>> I think though that instead of doing setlocale() it would be better to >>> pass some flag saying we're operating in a machine-readable mode, and >>> then we'd (as part of the protocol defintion) say we're going to emit >>> GIT_ERR_UPLOAD_ARCHIVE

Re: [PATCH 2/3] archive: implement protocol v2 archive command

2018-09-14 Thread Junio C Hamano
Jonathan Nieder writes: >> I think though that instead of doing setlocale() it would be better to >> pass some flag saying we're operating in a machine-readable mode, and >> then we'd (as part of the protocol defintion) say we're going to emit >> GIT_ERR_UPLOAD_ARCHIVE_EXPECTED_DELIM_PACKET or wh

Re: [PATCH 2/3] archive: implement protocol v2 archive command

2018-09-14 Thread Ævar Arnfjörð Bjarmason
On Fri, Sep 14 2018, Jonathan Nieder wrote: > Ævar Arnfjörð Bjarmason wrote: >> On Wed, Sep 12 2018, Stefan Beller wrote: > >>> Would asking for a setlocale() on the server side be an unreasonable >>> feature request for the capabilities (in a follow up patch, and then not >>> just for archive b

Re: [PATCH 2/3] archive: implement protocol v2 archive command

2018-09-13 Thread Jonathan Nieder
Ævar Arnfjörð Bjarmason wrote: > On Wed, Sep 12 2018, Stefan Beller wrote: >> Would asking for a setlocale() on the server side be an unreasonable >> feature request for the capabilities (in a follow up patch, and then not >> just for archive but also fetch/push, etc.)? > > This would be very nice

Re: [PATCH 2/3] archive: implement protocol v2 archive command

2018-09-13 Thread Jonathan Nieder
Hi, Josh Steadmon wrote: > This adds a new archive command for protocol v2. The command expects > arguments in the form "argument X" which are passed unmodified to > git-upload-archive--writer. > > This command works over the file://, Git, and SSH transports. HTTP > support will be added in a sep

Re: [PATCH 2/3] archive: implement protocol v2 archive command

2018-09-13 Thread Ævar Arnfjörð Bjarmason
On Wed, Sep 12 2018, Stefan Beller wrote: > On Tue, Sep 11, 2018 at 10:36 PM Josh Steadmon wrote: >> +*/ >> + status = packet_reader_read(&reader); >> + } >> + if (status != PACKET_READ_DELIM) >> + die(_("upload-archive: expected delim pac

Re: [PATCH 2/3] archive: implement protocol v2 archive command

2018-09-13 Thread Junio C Hamano
Josh Steadmon writes: > +static int do_v2_command_and_cap(int out) > +{ > + packet_write_fmt(out, "command=archive\n"); > + /* Capability list would go here, if we had any. */ > + packet_delim(out); > +} > + > static int run_remote_archiver(int argc, const char **argv, >

Re: [PATCH 2/3] archive: implement protocol v2 archive command

2018-09-12 Thread Stefan Beller
On Tue, Sep 11, 2018 at 10:36 PM Josh Steadmon wrote: > > This adds a new archive command for protocol v2. The command expects > arguments in the form "argument X" which are passed unmodified to > git-upload-archive--writer. > > This command works over the file://, Git, and SSH transports. HTTP >

[PATCH 2/3] archive: implement protocol v2 archive command

2018-09-11 Thread Josh Steadmon
This adds a new archive command for protocol v2. The command expects arguments in the form "argument X" which are passed unmodified to git-upload-archive--writer. This command works over the file://, Git, and SSH transports. HTTP support will be added in a separate patch. Signed-off-by: Josh Stea