Re: [PATCH 2/2] wincred: avoid overwriting configured variables

2014-05-14 Thread Erik Faye-Lund
On Wed, May 14, 2014 at 10:45 AM, Stepan Kasal wrote: > Hello kusma, > > On Tue, May 13, 2014 at 08:56:54AM +0200, Erik Faye-Lund wrote: >> > --- a/contrib/credential/wincred/Makefile >> > +++ b/contrib/credential/wincred/Makefile >> > @@ -1,12 +1,12 @@ >> > all: git-credential-wincred.exe >> > >

Re: [PATCH 2/2] wincred: avoid overwriting configured variables

2014-05-13 Thread Stepan Kasal
Hello, On Tue, May 13, 2014 at 08:18:26AM -0500, Felipe Contreras wrote: > Set by whom? If it's by the environment you should be running 'make -e'. ... or on command line (through recursive make, prehaps). But these both take precedence over makefile assignments. Another issue is the interaction

Re: [PATCH 2/2] wincred: avoid overwriting configured variables

2014-05-13 Thread Felipe Contreras
On Tue, May 13, 2014 at 1:34 AM, Erik Faye-Lund wrote: > On Tue, May 13, 2014 at 8:01 AM, Stepan Kasal wrote: >> From: Pat Thoyts >> Date: Wed, 24 Oct 2012 00:15:29 +0100 >> >> Signed-off-by: Pat Thoyts >> Signed-off-by: Stepan Kasal >> --- >> contrib/credential/wincred/Makefile | 4 >>

[PATCH 2/2] wincred: avoid overwriting configured variables

2014-05-12 Thread Stepan Kasal
From: Pat Thoyts Date: Wed, 24 Oct 2012 00:15:29 +0100 Signed-off-by: Pat Thoyts Signed-off-by: Stepan Kasal --- Hi kusma, On Tue, May 13, 2014 at 08:34:36AM +0200, Erik Faye-Lund wrote: > Would it be better to set these if not already set, i.e: > > -CC = gcc > -RM = rm -f > -CFLAGS = -O2 -W

Re: [PATCH 2/2] wincred: avoid overwriting configured variables

2014-05-12 Thread Erik Faye-Lund
On Tue, May 13, 2014 at 8:01 AM, Stepan Kasal wrote: > From: Pat Thoyts > Date: Wed, 24 Oct 2012 00:15:29 +0100 > > Signed-off-by: Pat Thoyts > Signed-off-by: Stepan Kasal > --- > contrib/credential/wincred/Makefile | 4 > 1 file changed, 4 deletions(-) > > diff --git a/contrib/credential

[PATCH 2/2] wincred: avoid overwriting configured variables

2014-05-12 Thread Stepan Kasal
From: Pat Thoyts Date: Wed, 24 Oct 2012 00:15:29 +0100 Signed-off-by: Pat Thoyts Signed-off-by: Stepan Kasal --- contrib/credential/wincred/Makefile | 4 1 file changed, 4 deletions(-) diff --git a/contrib/credential/wincred/Makefile b/contrib/credential/wincred/Makefile index 39fa5e0..