Re: [PATCH 2/2] version --build-options: report commit, too, if possible

2017-12-14 Thread Johannes Schindelin
Hi Junio, On Fri, 8 Dec 2017, Junio C Hamano wrote: > Jonathan Nieder writes: > > >> We need to be careful, though, to report when the current commit cannot be > >> determined, e.g. when building from a tarball without any associated Git > >> repository. > > > > This means that on Debian, it wo

Re: [PATCH 2/2] version --build-options: report commit, too, if possible

2017-12-14 Thread Johannes Schindelin
Hi Jonathan, On Fri, 8 Dec 2017, Jonathan Nieder wrote: > Johannes Schindelin wrote: > > > In particular when local tags are used (or tags that are pushed to some > > fork) to build Git, it is very hard to figure out from which particular > > revision a particular Git executable was built. > >

Re: [PATCH 2/2] version --build-options: report commit, too, if possible

2017-12-08 Thread Junio C Hamano
Jonathan Nieder writes: >> We need to be careful, though, to report when the current commit cannot be >> determined, e.g. when building from a tarball without any associated Git >> repository. > > This means that on Debian, it would always print > > built from commit: (unknown) > > Maybe I

Re: [PATCH 2/2] version --build-options: report commit, too, if possible

2017-12-08 Thread Jonathan Nieder
Hi, Johannes Schindelin wrote: > In particular when local tags are used (or tags that are pushed to some > fork) to build Git, it is very hard to figure out from which particular > revision a particular Git executable was built. Hm, can you say more about how this comes up in practice? I wonder

[PATCH 2/2] version --build-options: report commit, too, if possible

2017-12-08 Thread Johannes Schindelin
In particular when local tags are used (or tags that are pushed to some fork) to build Git, it is very hard to figure out from which particular revision a particular Git executable was built. Let's just report that in our build options. We need to be careful, though, to report when the current co