Re: [PATCH 2/2] version-gen: avoid messing the version

2013-09-09 Thread Felipe Contreras
On Mon, Sep 9, 2013 at 6:30 PM, brian m. carlson wrote: > On Mon, Sep 09, 2013 at 02:00:55AM -0500, Felipe Contreras wrote: >> Of course not. First of all, who exactly is packaging release >> candidates nowadays? And second, why they can't they use the existing >> tools, like the 'version' file? >

Re: [PATCH 2/2] version-gen: avoid messing the version

2013-09-09 Thread brian m. carlson
On Mon, Sep 09, 2013 at 02:00:55AM -0500, Felipe Contreras wrote: > Of course not. First of all, who exactly is packaging release > candidates nowadays? And second, why they can't they use the existing > tools, like the 'version' file? Debian unstable, for one. However, they don't use RPMs and th

Re: [PATCH 2/2] version-gen: avoid messing the version

2013-09-09 Thread Felipe Contreras
On Mon, Sep 9, 2013 at 12:51 AM, Junio C Hamano wrote: > Felipe Contreras writes: > >> If the version is 'v1.8.4-rc1' that is the version, and there's no need >> to change it to anything else, like 'v1.8.4.rc1'. >> >> Signed-off-by: Felipe Contreras >> --- >> GIT-VERSION-GEN | 1 - >> 1 file ch

Re: [PATCH 2/2] version-gen: avoid messing the version

2013-09-08 Thread Junio C Hamano
Felipe Contreras writes: > If the version is 'v1.8.4-rc1' that is the version, and there's no need > to change it to anything else, like 'v1.8.4.rc1'. > > Signed-off-by: Felipe Contreras > --- > GIT-VERSION-GEN | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/GIT-VERSION-GEN b/GIT-VERSIO

[PATCH 2/2] version-gen: avoid messing the version

2013-09-08 Thread Felipe Contreras
If the version is 'v1.8.4-rc1' that is the version, and there's no need to change it to anything else, like 'v1.8.4.rc1'. Signed-off-by: Felipe Contreras --- GIT-VERSION-GEN | 1 - 1 file changed, 1 deletion(-) diff --git a/GIT-VERSION-GEN b/GIT-VERSION-GEN index b0db139..2b9fd2f 100755 --- a/G