Hi Martin,
On Sat, Apr 28, 2018 at 4:32 AM, Martin Ågren wrote:
> As you noted elsewhere [1], Ben is also working in this area. I'd be
> perfectly happy to sit on these patches until both of your contributions
> come through to master.
>
> [1]
> https://public-inbox.org/git/CABPp-BFh=gl6rnbst2bg
Hi Martin,
On Sat, Apr 28, 2018 at 4:32 AM, Martin Ågren wrote:
> From: Elijah Newren
>
> Hi Elijah,
>
> [Since this is leaving the topic of rename-detection in favour of
> leak-plugging, I'm shortening the cc-list a bit.]
>
>> So, instead, I'd like to see something like the below
>> (built on t
Hi Martin,
On Sat, 28 Apr 2018, Martin Ågren wrote:
> -->8--
> Subject: merge-recursive: provide pair of `unpack_trees_{start,finish}()`
>
> Rename `git_merge_trees()` to `unpack_trees_start()` and extract the
> call to `discard_index()` into a new function `unpack_trees_finish()`.
> As a result
From: Elijah Newren
Hi Elijah,
[Since this is leaving the topic of rename-detection in favour of
leak-plugging, I'm shortening the cc-list a bit.]
> So, instead, I'd like to see something like the below
> (built on top of my series):
Thanks a lot. I now have the below patch in my tree as a pr
On Mon, Apr 23, 2018 at 10:13 PM, Martin Ågren wrote:
> The strings allocated in `setup_unpack_trees_porcelain()` are never
> freed. Provide a function `clear_unpack_trees_porcelain()` to do so and
> call it in the functions which use `setup_unpack_trees_porcelain()`.
This is awesome; thanks.
>
The strings allocated in `setup_unpack_trees_porcelain()` are never
freed. Provide a function `clear_unpack_trees_porcelain()` to do so and
call it in the functions which use `setup_unpack_trees_porcelain()`.
In all current callers, the pointers are about to go out of scope, so we
do not need to s
6 matches
Mail list logo
