Re: [PATCH 2/2] transport-helper: fix remote helper namespace regression

2013-05-10 Thread Junio C Hamano
Felipe Contreras writes: > On Fri, May 10, 2013 at 3:28 PM, Junio C Hamano wrote: >> Felipe Contreras writes: >> >>> +test_expect_success 'push update refs failure' ' >>> + (cd local && >>> + git checkout update && >>> + echo "update fail" >>file && >>> + git commit -a -m "updat

Re: [PATCH 2/2] transport-helper: fix remote helper namespace regression

2013-05-10 Thread Felipe Contreras
On Fri, May 10, 2013 at 3:28 PM, Junio C Hamano wrote: > Felipe Contreras writes: > >> +test_expect_success 'push update refs failure' ' >> + (cd local && >> + git checkout update && >> + echo "update fail" >>file && >> + git commit -a -m "update fail" && >> + git rev-parse --

Re: [PATCH 2/2] transport-helper: fix remote helper namespace regression

2013-05-10 Thread Junio C Hamano
Felipe Contreras writes: > +test_expect_success 'push update refs failure' ' > + (cd local && > + git checkout update && > + echo "update fail" >>file && > + git commit -a -m "update fail" && > + git rev-parse --verify testgit/origin/heads/update >expect && > + GIT_REMOTE_

Re: [PATCH 2/2] transport-helper: fix remote helper namespace regression

2013-05-10 Thread Junio C Hamano
Felipe Contreras writes: > Commit 664059f (transport-helper: update remote helper namespace) > updates the namespace when the push succeeds or not; we should do it > only when it succeeded. > > Signed-off-by: Felipe Contreras > --- > > The regression is in 'next' so far. Thanks. As you may wel

[PATCH 2/2] transport-helper: fix remote helper namespace regression

2013-05-10 Thread Felipe Contreras
Commit 664059f (transport-helper: update remote helper namespace) updates the namespace when the push succeeds or not; we should do it only when it succeeded. Signed-off-by: Felipe Contreras --- The regression is in 'next' so far. git-remote-testgit.sh | 7 ++- t/t5801-remote-helpers.