Re: [PATCH 2/2] test-lib.sh: Dynamic test for the prerequisite SANITY

2015-01-28 Thread Torsten Bögershausen
On 27.01.15 23:20, Junio C Hamano wrote: > How about extending it like this (not tested)? Thanks, this looks good: the test is more extensive, I can test this next week. > > -- >8 -- > From: Torsten Bögershausen > Date: Tue, 27 Jan 2015 16:39:01 +0100 > Subject: [PATCH] test-lib.sh: set prerequ

Re: [PATCH 2/2] test-lib.sh: Dynamic test for the prerequisite SANITY

2015-01-28 Thread Junio C Hamano
Torsten Bögershausen writes: >> OK, but MacOS X does not have SANITY problem; "is the / writable?" test >> was misdetecting and declaring a system with SANITY does not have one. >> >> Perhaps roll Cygwin and Mingw into a single Windows category? I dunno. > The whole discussion actually started wi

Re: [PATCH 2/2] test-lib.sh: Dynamic test for the prerequisite SANITY

2015-01-28 Thread Junio C Hamano
On Wed, Jan 28, 2015 at 12:28 AM, Torsten Bögershausen wrote: > On 27.01.15 23:20, Junio C Hamano wrote: > >> How about extending it like this (not tested)? > Thanks, this looks good: the test is more extensive, > I can test this next week. > >> >> -- >8 -- >> From: Torsten Bögershausen >> Date:

Re: [PATCH 2/2] test-lib.sh: Dynamic test for the prerequisite SANITY

2015-01-28 Thread Torsten Bögershausen
On 28.01.15 18:38, Junio C Hamano wrote: > On Wed, Jan 28, 2015 at 12:28 AM, Torsten Bögershausen wrote: >> On 27.01.15 23:20, Junio C Hamano wrote: >> >>> How about extending it like this (not tested)? >> Thanks, this looks good: the test is more extensive, >> I can test this next week. >> >>> -

Re: [PATCH 2/2] test-lib.sh: Dynamic test for the prerequisite SANITY

2015-01-27 Thread Junio C Hamano
Torsten Bögershausen writes: > # When the tests are run as root, permission tests will report that > # things are writable when they shouldn't be. This no longer is relevant, I think. > +# Special check for CYGWIN (or Windows in general): Misleading comment in the end result, as your new tes

Re: [PATCH 2/2] test-lib.sh: Dynamic test for the prerequisite SANITY

2015-01-27 Thread Chris Packham
Minor typo in a comment. On Wed, Jan 28, 2015 at 4:39 AM, Torsten Bögershausen wrote: > The SANITY precondition was not set when running as root, > but this is not 100% reliable for CYGWIN: > > A file may be allowed to be deleted when the containing > directory does not have write permissions. >

[PATCH 2/2] test-lib.sh: Dynamic test for the prerequisite SANITY

2015-01-27 Thread Torsten Bögershausen
The SANITY precondition was not set when running as root, but this is not 100% reliable for CYGWIN: A file may be allowed to be deleted when the containing directory does not have write permissions. See https://technet.microsoft.com/en-us/library/bb463216.aspx "...In UNIX, the write permission bi