[PATCH 2/2] rm: introduce advice.rmHints to shorten messages

2013-06-12 Thread Mathieu Lienard--Mayor
Introduce advice.rmHints to choose whether to display advice or not when git rm fails. Defaults to true, in order to preserve current behavior. As an example, the message: error: 'foo.txt' has changes staged in the index (use --cached to keep the file, or -f to force removal) woul

Re: [PATCH 2/2] rm: introduce advice.rmHints to shorten messages

2013-06-10 Thread Mathieu Liénard--Mayor
Le 2013-06-10 18:57, Junio C Hamano a écrit : Mathieu Liénard--Mayor writes: Please ignore this, manipulation error while in the git send-email command line. Here is what my mailbox looks like (the penultimate one with 252 lines is what I am responding to). R. [ 146: Mathieu Lienard--May

Re: [PATCH 2/2] rm: introduce advice.rmHints to shorten messages

2013-06-10 Thread Junio C Hamano
Mathieu Liénard--Mayor writes: > Please ignore this, manipulation error while in the git send-email > command line. Here is what my mailbox looks like (the penultimate one with 252 lines is what I am responding to). R. [ 146: Mathieu Lienard--Mayor ] [PATCH 1/2] rm: better error messa R.

[PATCH 2/2] rm: introduce advice.rmHints to shorten messages

2013-06-10 Thread Mathieu Lienard--Mayor
Introduce advice.rmHints to choose whether to display advice or not when git rm fails. Defaults to true, in order to preserve current behavior. As an example, the message: error: 'foo.txt' has changes staged in the index (use --cached to keep the file, or -f to force removal) woul

Re: [PATCH 2/2] rm: introduce advice.rmHints to shorten messages

2013-06-10 Thread Mathieu Liénard--Mayor
Please ignore this, manipulation error while in the git send-email command line. Le 2013-06-10 14:51, Mathieu Lienard--Mayor a écrit : Introduce advice.rmHints to choose whether to display advice or not when git rm fails. Defaults to true, in order to preserve current behavior. As an example

[PATCH 2/2] rm: introduce advice.rmHints to shorten messages

2013-06-10 Thread Mathieu Lienard--Mayor
Introduce advice.rmHints to choose whether to display advice or not when git rm fails. Defaults to true, in order to preserve current behavior. As an example, the message: error: 'foo.txt' has changes staged in the index (use --cached to keep the file, or -f to force removal) woul

Re: [PATCH 2/2] rm: introduce advice.rmHints to shorten messages

2013-06-10 Thread Ramkumar Ramachandra
Matthieu Moy wrote: > I don't see why add and rm hints should be correlated, or I don't have > the same advice as you in mind. > > Both have completely different meanings: the first is about .gitignore, > and the second about not loosing data. Right, my bad. Please continue with rmHints, and opti

Re: [PATCH 2/2] rm: introduce advice.rmHints to shorten messages

2013-06-10 Thread Matthieu Moy
Ramkumar Ramachandra writes: > Mathieu Liénard--Mayor wrote: >> I'm not so sure i understand. Do you mean rmHints should deactivate addHints >> aswell, or do you mean that since we're introducing rmHints it would be >> natural to introduce addHints ? > > More the latter, but I'm tilting towards a

Re: [PATCH 2/2] rm: introduce advice.rmHints to shorten messages

2013-06-10 Thread Ramkumar Ramachandra
Mathieu Liénard--Mayor wrote: > I'm not so sure i understand. Do you mean rmHints should deactivate addHints > aswell, or do you mean that since we're introducing rmHints it would be > natural to introduce addHints ? More the latter, but I'm tilting towards addRmHints (or something) which affects

Re: [PATCH 2/2] rm: introduce advice.rmHints to shorten messages

2013-06-10 Thread Mathieu Liénard--Mayor
Le 2013-06-08 16:01, Ramkumar Ramachandra a écrit : Mathieu Lienard--Mayor wrote: As an example, the message: error: 'foo.txt' has changes staged in the index (use --cached to keep the file, or -f to force removal) would look like, with advice.rmHints=true: error: 'foo.t

Re: [PATCH 2/2] rm: introduce advice.rmHints to shorten messages

2013-06-08 Thread Ramkumar Ramachandra
Mathieu Lienard--Mayor wrote: > As an example, the message: > error: 'foo.txt' has changes staged in the index > (use --cached to keep the file, or -f to force removal) > > would look like, with advice.rmHints=true: > error: 'foo.txt' has changes staged in the index Um, hav

[PATCH 2/2] rm: introduce advice.rmHints to shorten messages

2013-06-08 Thread Mathieu Lienard--Mayor
From: Mathieu Liénard--Mayor Similarly to advice.*, advice.rmHints has been added to the config variables. By default, it is set to false, in order to keep the messages the same as before. When set to true, advice are no longer included in the error messages. As an example, the message: