Re: [PATCH 2/2] refs: support negative transfer.hideRefs

2015-07-30 Thread Jeff King
On Thu, Jul 30, 2015 at 04:17:35PM -0400, Eric Sunshine wrote: > > + test_expect_success "Override hiding of $configsection.hiderefs" ' > > + test_when_finished "test_unconfig $configsection.hiderefs" > > && > > + git config --add $configsection.hiderefs refs/tag

Re: [PATCH 2/2] refs: support negative transfer.hideRefs

2015-07-30 Thread Eric Sunshine
On Tue, Jul 28, 2015 at 3:59 PM, Jeff King wrote: > If you hide a hierarchy of refs using the transfer.hideRefs > config, there is no way to later override that config to > "unhide" it. This patch implements a "negative" hide which > causes matches to immediately be marked as unhidden, even if > a

Re: [PATCH 2/2] refs: support negative transfer.hideRefs

2015-07-28 Thread Jeff King
On Tue, Jul 28, 2015 at 01:14:47PM -0700, Junio C Hamano wrote: > I notice that the only time you said that you chose '!' prefix as > the way to express this new "negative" is as a side note to the > rejected second variant ;-). The first paragraph would have been a > good place to say that, beca

Re: [PATCH 2/2] refs: support negative transfer.hideRefs

2015-07-28 Thread Junio C Hamano
Jeff King writes: > If you hide a hierarchy of refs using the transfer.hideRefs > config, there is no way to later override that config to > "unhide" it. This patch implements a "negative" hide which > causes matches to immediately be marked as unhidden, even if > another match would hide it. We

[PATCH 2/2] refs: support negative transfer.hideRefs

2015-07-28 Thread Jeff King
If you hide a hierarchy of refs using the transfer.hideRefs config, there is no way to later override that config to "unhide" it. This patch implements a "negative" hide which causes matches to immediately be marked as unhidden, even if another match would hide it. We take care to apply the matches