"Keller, Jacob E" writes:
>> > s/hangled/handled/
>> > ...
>>
>> Thanks; here is what I queued yesterday.
>>
>
> Woah. I bow to your imperative commit message abilities. The new commit
> message is very nicely worded.
Heh, imperative is secondary. I just wanted to straighten out the
use of "re
On Thu, 2015-07-23 at 15:12 -0700, Junio C Hamano wrote:
> Eric Sunshine writes:
>
> > On Wed, Jul 22, 2015 at 5:05 PM, Jacob Keller <
> > jacob.e.kel...@intel.com> wrote:
> > > From: Jacob Keller
> > >
> > > Modify logic of check_refname_component and add a new disposition
> > > regarding "*".
Eric Sunshine writes:
> On Wed, Jul 22, 2015 at 5:05 PM, Jacob Keller
> wrote:
>> From: Jacob Keller
>>
>> Modify logic of check_refname_component and add a new disposition
>> regarding "*". Allow refspecs that contain a single "*" if
>> REFNAME_REFSPEC_PATTERN is set. Change the function to p
On Wed, Jul 22, 2015 at 5:05 PM, Jacob Keller wrote:
> From: Jacob Keller
>
> Modify logic of check_refname_component and add a new disposition
> regarding "*". Allow refspecs that contain a single "*" if
> REFNAME_REFSPEC_PATTERN is set. Change the function to pass the flags as
> a pointer, and
On Thu, Jul 23, 2015 at 9:44 AM, Junio C Hamano wrote:
> Jacob Keller writes:
>
>>> By the way, have you run test suite before sending this (or any
>>> previous round of this) patch? This seems to break t5511-refspec.sh
>>> for me.
>>
>> Looks like another location I forgot to update. I can send
On Thu, Jul 23, 2015 at 10:13 AM, Junio C Hamano wrote:
> That was whitespace damaged, so I had to hand-tweak the file in
> place. While at it, I noticed that we do not check a case where
> multiple asterisks appear in a single component (which is rejected
> for a reason different from having mul
Junio C Hamano writes:
> Will squash the changes; no need to resend (unless people discover
> other issues; let's hope that I wouldn't be the one to do so ;-).
>
> Thanks.
>
>> diff --git i/t/t5511-refspec.sh w/t/t5511-refspec.sh
>> index de6db86ccff0..7bfca7962d41 100755
>> --- i/t/t5511-refspec
Jacob Keller writes:
>> By the way, have you run test suite before sending this (or any
>> previous round of this) patch? This seems to break t5511-refspec.sh
>> for me.
>
> Looks like another location I forgot to update. I can send a re-spin
> if you need with the following diff. Basically look
On Wed, Jul 22, 2015 at 3:04 PM, Junio C Hamano wrote:
> Jacob Keller writes:
>
>> From: Jacob Keller
>>
>> Modify logic of check_refname_component and add a new disposition
>> regarding "*". Allow refspecs that contain a single "*" if
>> REFNAME_REFSPEC_PATTERN is set. Change the function to pa
Jacob Keller writes:
> From: Jacob Keller
>
> Modify logic of check_refname_component and add a new disposition
> regarding "*". Allow refspecs that contain a single "*" if
> REFNAME_REFSPEC_PATTERN is set. Change the function to pass the flags as
> a pointer, and clear REFNAME_REFSPEC_PATTERN a
From: Jacob Keller
Modify logic of check_refname_component and add a new disposition
regarding "*". Allow refspecs that contain a single "*" if
REFNAME_REFSPEC_PATTERN is set. Change the function to pass the flags as
a pointer, and clear REFNAME_REFSPEC_PATTERN after the first "*" so that
only a
11 matches
Mail list logo