Re: [PATCH 2/2] mingw: allow absolute paths without drive prefix

2018-12-14 Thread Johannes Schindelin
Hi Hannes, On Thu, 13 Dec 2018, Johannes Sixt wrote: > Am 13.12.18 um 07:25 schrieb Johannes Sixt: > > Am 13.12.18 um 03:48 schrieb Junio C Hamano: > > > So,... what's the conclusion?  The patch in the context of my tree > > > would be a no-op, and we'd need a prerequisite change to the support >

Re: [PATCH 2/2] mingw: allow absolute paths without drive prefix

2018-12-13 Thread Johannes Sixt
Am 13.12.18 um 07:25 schrieb Johannes Sixt: Am 13.12.18 um 03:48 schrieb Junio C Hamano: So,... what's the conclusion?  The patch in the context of my tree would be a no-op, and we'd need a prerequisite change to the support function to accompany this patch to be effective? Correct, that is my

Re: [PATCH 2/2] mingw: allow absolute paths without drive prefix

2018-12-12 Thread Johannes Sixt
Am 13.12.18 um 03:48 schrieb Junio C Hamano: So,... what's the conclusion? The patch in the context of my tree would be a no-op, and we'd need a prerequisite change to the support function to accompany this patch to be effective? Correct, that is my conclusion. -- Hannes

Re: [PATCH 2/2] mingw: allow absolute paths without drive prefix

2018-12-12 Thread Junio C Hamano
Johannes Sixt writes: + if (is_dir_sep(template[0]) && !is_dir_sep(template[1]) && + iswalpha(wtemplate[0]) && wtemplate[1] == L':') { + /* We have an absolute path missing the drive prefix */ >>> >>> This comment is true for the source part, template, but I can't fi

Re: [PATCH 2/2] mingw: allow absolute paths without drive prefix

2018-12-11 Thread Johannes Sixt
Am 11.12.18 um 12:25 schrieb Johannes Schindelin: On Mon, 10 Dec 2018, Johannes Sixt wrote: diff --git a/compat/mingw.c b/compat/mingw.c index 34b3880b29..4d009901d8 100644 --- a/compat/mingw.c +++ b/compat/mingw.c @@ -928,11 +928,19 @@ unsigned int sleep (unsigned int seconds) char *mingw_mk

Re: [PATCH 2/2] mingw: allow absolute paths without drive prefix

2018-12-11 Thread Johannes Schindelin
Hi Hannes, On Mon, 10 Dec 2018, Johannes Sixt wrote: > > diff --git a/compat/mingw.c b/compat/mingw.c > > index 34b3880b29..4d009901d8 100644 > > --- a/compat/mingw.c > > +++ b/compat/mingw.c > > @@ -928,11 +928,19 @@ unsigned int sleep (unsigned int seconds) > > char *mingw_mktemp(char *templa

Re: [PATCH 2/2] mingw: allow absolute paths without drive prefix

2018-12-10 Thread Johannes Sixt
Am 10.12.18 um 19:47 schrieb Johannes Schindelin via GitGitGadget: From: Johannes Schindelin When specifying an absolute path without a drive prefix, we convert that path internally. Let's make sure that we handle that case properly, too ;-) This fixes the command git clone https://gi

[PATCH 2/2] mingw: allow absolute paths without drive prefix

2018-12-10 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin When specifying an absolute path without a drive prefix, we convert that path internally. Let's make sure that we handle that case properly, too ;-) This fixes the command git clone https://github.com/git-for-windows/git \G4W Signed-off-by: Johannes Schindelin