Jeff King writes:
> However, that is _not_ what we currently do with run-command's
> use_shell directive. There we put SHELL_PATH as argv[0], and run:
>
> execv(argv[0], argv);
> ...
> If we want to maintain consistency with the rest of our uses of
> run-command, it would be just your original:
On Sun, Mar 08, 2015 at 11:32:22PM -0700, Kyle J. McKay wrote:
> >It is a common convention to make the first argument the command
> >name without its path, and this change breaks that convention.
>
> Hmpf. I present these for your consideration:
>
> $ sh -c 'echo $0'
> sh
> $ /bin/sh -c 'echo
On Mar 7, 2015, at 23:52, Junio C Hamano wrote:
"Kyle J. McKay" writes:
If the user has set SHELL_PATH in the Makefile then we
should respect that value and use it.
Signed-off-by: Kyle J. McKay
---
builtin/help.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/help
"Kyle J. McKay" writes:
> If the user has set SHELL_PATH in the Makefile then we
> should respect that value and use it.
>
> Signed-off-by: Kyle J. McKay
> ---
> builtin/help.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/help.c b/builtin/help.c
> index 6133f
If the user has set SHELL_PATH in the Makefile then we
should respect that value and use it.
Signed-off-by: Kyle J. McKay
---
builtin/help.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/help.c b/builtin/help.c
index 6133fe49..2ae8a1e9 100644
--- a/builtin/help.c
++
5 matches
Mail list logo
