Re: [PATCH 2/2] grep: refactor and simplify PCRE1 support

2019-08-26 Thread Junio C Hamano
Carlo Marcelo Arenas Belón writes: > diff --git a/grep.h b/grep.h > index 1a044c501e..ff620d784a 100644 > --- a/grep.h > +++ b/grep.h > @@ -3,15 +3,6 @@ > #include "color.h" > #ifdef USE_LIBPCRE1 > #include > -#ifndef NO_LIBPCRE1_JIT > -#ifdef PCRE_CONFIG_JIT > -#define GIT_PCRE1_USE_JIT > -

[PATCH 2/2] grep: refactor and simplify PCRE1 support

2019-08-25 Thread Carlo Marcelo Arenas Belón
The code used both a macro and a variable to keep track if JIT support was desired and relied on the fact that a non JIT enabled library will ignore a request for JIT compilation (as defined by the second parameter of the call to pcre_study) Cleanup the multiple levels of macros used and call pcre

[RFC PATCH 2/2] grep: refactor and simplify PCRE1 support

2019-07-26 Thread Carlo Marcelo Arenas Belón
The code used both a macro and a variable to keep track if JIT support was desired and relied on the fact that a non JIT enabled library will ignore a request for JIT compilation (as defined by the second parameter of the call to pcre_study) Cleanup the multiple levels of macros used and call pcre