Re: [PATCH 2/2] diffcore-rename: avoid processing duplicate destinations

2015-02-27 Thread Junio C Hamano
Jeff King writes: > Like I mentioned before, I'm OK with not checking the actual diff output > in the test. It's not like it was planned, and is just what diff_tree() > happens to produce. It does make sense, though When the topic is on processing broken input, I do not think "It does make

[PATCH 2/2] diffcore-rename: avoid processing duplicate destinations

2015-02-26 Thread Jeff King
The rename code cannot handle an input where we have duplicate destinations (i.e., more than one diff_filepair in the queue with the same string in its pair->two->path). We end up allocating only one slot in the rename_dst mapping. If we fill in the diff_filepair for that slot, when we re-queue the