Re: [PATCH 2/2] diff: document the pattern format for diff.orderFile

2017-01-11 Thread Junio C Hamano
Richard Hansen writes: >> Back then we didn't even have wildmatch(), and used fnmatch() >> instead, so forcing FNM_PATHNAME would have meant that people >> wouldn't be able to say "foo*bar" to match "foo/other/bar"; with >> wildmatch, "foo**bar" lets you defeat WM_PATHNAME so having >> WM_PATHNAM

Re: [PATCH 2/2] diff: document the pattern format for diff.orderFile

2017-01-11 Thread Richard Hansen
On 2017-01-11 13:15, Junio C Hamano wrote: Richard Hansen writes: On 2017-01-10 21:46, Junio C Hamano wrote: Richard Hansen writes: I was looking at the code to see how the two file formats differed and noticed that match_order() doesn't set the WM_PATHNAME flag when it calls wildmatch().

Re: [PATCH 2/2] diff: document the pattern format for diff.orderFile

2017-01-11 Thread Junio C Hamano
Richard Hansen writes: > On 2017-01-10 21:46, Junio C Hamano wrote: >> Richard Hansen writes: >> >>> I was looking at the code to see how the two file formats differed and >>> noticed that match_order() doesn't set the WM_PATHNAME flag when it >>> calls wildmatch(). That's unintentional (a bug)

Re: [PATCH 2/2] diff: document the pattern format for diff.orderFile

2017-01-11 Thread Richard Hansen
On 2017-01-10 21:46, Junio C Hamano wrote: Richard Hansen writes: I was looking at the code to see how the two file formats differed and noticed that match_order() doesn't set the WM_PATHNAME flag when it calls wildmatch(). That's unintentional (a bug), right? It has been that way from day

Re: [PATCH 2/2] diff: document the pattern format for diff.orderFile

2017-01-10 Thread Junio C Hamano
Richard Hansen writes: > I was looking at the code to see how the two file formats differed and > noticed that match_order() doesn't set the WM_PATHNAME flag when it > calls wildmatch(). That's unintentional (a bug), right? It has been that way from day one IIRC even before we introduced wildma

Re: [PATCH 2/2] diff: document the pattern format for diff.orderFile

2017-01-10 Thread Richard Hansen
On 2017-01-10 15:14, Junio C Hamano wrote: Richard Hansen writes: Document the format of the patterns used for the diff.orderFile setting and diff's '-O' option by referring the reader to the gitignore[5] page. Signed-off-by: Richard Hansen --- Documentation/diff-config.txt | 3 ++- Docume

Re: [PATCH 2/2] diff: document the pattern format for diff.orderFile

2017-01-10 Thread Junio C Hamano
Richard Hansen writes: > Document the format of the patterns used for the diff.orderFile > setting and diff's '-O' option by referring the reader to the > gitignore[5] page. > > Signed-off-by: Richard Hansen > --- > Documentation/diff-config.txt | 3 ++- > Documentation/diff-options.txt | 3 ++

[PATCH 2/2] diff: document the pattern format for diff.orderFile

2017-01-09 Thread Richard Hansen
Document the format of the patterns used for the diff.orderFile setting and diff's '-O' option by referring the reader to the gitignore[5] page. Signed-off-by: Richard Hansen --- Documentation/diff-config.txt | 3 ++- Documentation/diff-options.txt | 3 ++- 2 files changed, 4 insertions(+), 2 d