Re: [PATCH 2/2] describe: add support for multiple match patterns

2016-12-07 Thread Jacob Keller
On Wed, Dec 7, 2016 at 4:20 PM, Junio C Hamano wrote: > Jacob Keller writes: > >> Basically, this started as a script to try each pattern in sequence, >> but this is slow, cumbersome and easy to mess up. >> >> You're suggesting just add a single second pattern that we will do >> matches and disca

Re: [PATCH 2/2] describe: add support for multiple match patterns

2016-12-07 Thread Junio C Hamano
Jacob Keller writes: > Basically, this started as a script to try each pattern in sequence, > but this is slow, cumbersome and easy to mess up. > > You're suggesting just add a single second pattern that we will do > matches and discard any tag that matches that first? I am not suggesting anythi

Re: [PATCH 2/2] describe: add support for multiple match patterns

2016-12-07 Thread Jacob Keller
On Wed, Dec 7, 2016 at 2:08 PM, Junio C Hamano wrote: > Jacob Keller writes: > >> ... Suppose that you version all >> your official releases such as "v1.2", "v1.3", "v1.4", "v2.1" and so on. >> Now, you also have other tags which represent -rc releases and other >> such tags. If you want to find

Re: [PATCH 2/2] describe: add support for multiple match patterns

2016-12-07 Thread Junio C Hamano
Jacob Keller writes: > ... Suppose that you version all > your official releases such as "v1.2", "v1.3", "v1.4", "v2.1" and so on. > Now, you also have other tags which represent -rc releases and other > such tags. If you want to find the first major release that contains > a given commit you mig

[PATCH 2/2] describe: add support for multiple match patterns

2016-12-06 Thread Jacob Keller
From: Jacob Keller Convert "--match" into a string list that accumulates patterns. If any patterns are given, then include all tags that match at least one pattern. This allows the user to construct multiple small patterns and compose them. If desired, a future patch could expand functionality by