Re: [PATCH 2/2] config: die when --blob is used outside a repository

2018-05-18 Thread Taylor Blau
On Fri, May 18, 2018 at 03:27:04PM -0700, Jeff King wrote: > If you run "config --blob" outside of a repository, then we > eventually try to resolve the blob name and hit a BUG(). > Let's catch this earlier and provide a useful message. I think that this approach is sensible. Let's (1) fix a SIGSE

[PATCH 2/2] config: die when --blob is used outside a repository

2018-05-18 Thread Jeff King
If you run "config --blob" outside of a repository, then we eventually try to resolve the blob name and hit a BUG(). Let's catch this earlier and provide a useful message. Note that we could also catch this much lower in the stack, in git_config_from_blob_ref(). That might cover other callsites, t