Re: [PATCH 2/2] config: clear the executable bits (if any) on $GIT_DIR/config

2014-11-17 Thread Michael Haggerty
On 11/17/2014 04:33 PM, Junio C Hamano wrote: > Michael Haggerty writes: > >> On 11/16/2014 07:49 PM, Junio C Hamano wrote: >> ... >>> So I would suggest not to spend any cycle or any code complexity to >>> "repair" existing repositories. Having that bit on does not hurt >>> anybody. Those who

Re: [PATCH 2/2] config: clear the executable bits (if any) on $GIT_DIR/config

2014-11-17 Thread Junio C Hamano
Michael Haggerty writes: > On 11/16/2014 07:49 PM, Junio C Hamano wrote: > ... >> So I would suggest not to spend any cycle or any code complexity to >> "repair" existing repositories. Having that bit on does not hurt >> anybody. Those who found it curious can flip that bit off and then >> Git

Re: [PATCH 2/2] config: clear the executable bits (if any) on $GIT_DIR/config

2014-11-17 Thread Michael Haggerty
On 11/16/2014 07:49 PM, Junio C Hamano wrote: > Michael Haggerty writes: > >> There is no reason for $GIT_DIR/config to be executable, plus this >> change will help clean up repositories affected by the bug that was >> fixed by the previous commit. > > I do not think we want to do this. > > It

Re: [PATCH 2/2] config: clear the executable bits (if any) on $GIT_DIR/config

2014-11-16 Thread Junio C Hamano
Michael Haggerty writes: > There is no reason for $GIT_DIR/config to be executable, plus this > change will help clean up repositories affected by the bug that was > fixed by the previous commit. I do not think we want to do this. It is a welcome bugfix to create $GIT_DIR/config without executa

Re: [PATCH 2/2] config: clear the executable bits (if any) on $GIT_DIR/config

2014-11-14 Thread Michael Haggerty
On 11/15/2014 08:32 AM, Stefan Beller wrote: > On 14.11.2014 23:26, Michael Haggerty wrote: >> There is no reason for $GIT_DIR/config to be executable, plus this >> change will help clean up repositories affected by the bug that was >> fixed by the previous commit. >> >> Signed-off-by: Michael Hagg

Re: [PATCH 2/2] config: clear the executable bits (if any) on $GIT_DIR/config

2014-11-14 Thread Stefan Beller
On 14.11.2014 23:26, Michael Haggerty wrote: > There is no reason for $GIT_DIR/config to be executable, plus this > change will help clean up repositories affected by the bug that was > fixed by the previous commit. > > Signed-off-by: Michael Haggerty > --- > config.c | 12 ++-- > 1 file

[PATCH 2/2] config: clear the executable bits (if any) on $GIT_DIR/config

2014-11-14 Thread Michael Haggerty
There is no reason for $GIT_DIR/config to be executable, plus this change will help clean up repositories affected by the bug that was fixed by the previous commit. Signed-off-by: Michael Haggerty --- config.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/conf