Re: [PATCH 2/2] color: support "italic" attribute

On Thu, Jun 23, 2016 at 09:46:57AM -0700, Junio C Hamano wrote: > > diff --git a/Documentation/config.txt b/Documentation/config.txt > > index 58673cf..4b97d8d 100644 > > --- a/Documentation/config.txt > > +++ b/Documentation/config.txt > > @@ -154,7 +154,7 @@ color:: > > colors (at most t

Re: [PATCH 2/2] color: support "italic" attribute

Jeff King writes: > We already support bold, underline, and similar attributes. > Let's add italic to the mix. According to the Wikipedia > page on ANSI colors, this attribute is "not widely > supported", but it does seem to work on my xterm. > > We don't have to bump the maximum color size beca

Re: [PATCH 2/2] color: support "italic" attribute

Wow I wasn't expecting such a rapid response, you're awesome! :-D Simon Courtois On 23 June 2016 at 15:10:33, Jeff King (p...@peff.net) wrote: > We already support bold, underline, and similar attributes. > Let's add italic to the mix. According to the Wikipedia > page on ANSI colors, this attrib

[PATCH 2/2] color: support "italic" attribute

We already support bold, underline, and similar attributes. Let's add italic to the mix. According to the Wikipedia page on ANSI colors, this attribute is "not widely supported", but it does seem to work on my xterm. We don't have to bump the maximum color size because we were already over-alloca