Re: Re* [PATCH 2/2] check-ignore.c: fix segfault with '.' argument from repo root

2013-02-21 Thread Junio C Hamano
Adam Spiers writes: > On Tue, Feb 19, 2013 at 06:53:07PM -0800, Junio C Hamano wrote: >> Adam Spiers writes: >> >> > OK, thanks for the information. IMHO it would be nice if 'git >> > format-patch' and 'git am' supported this style of inline patch >> > inclusion, but maybe there are good reaso

Re: Re* [PATCH 2/2] check-ignore.c: fix segfault with '.' argument from repo root

2013-02-20 Thread Adam Spiers
On Tue, Feb 19, 2013 at 06:53:07PM -0800, Junio C Hamano wrote: > Adam Spiers writes: > > > OK, thanks for the information. IMHO it would be nice if 'git > > format-patch' and 'git am' supported this style of inline patch > > inclusion, but maybe there are good reasons to discourage it? > > "gi

Re: Re* [PATCH 2/2] check-ignore.c: fix segfault with '.' argument from repo root

2013-02-19 Thread Junio C Hamano
Adam Spiers writes: > OK, thanks for the information. IMHO it would be nice if 'git > format-patch' and 'git am' supported this style of inline patch > inclusion, but maybe there are good reasons to discourage it? "git am --scissors" is a way to process such e-mail where the patch submitter con

Re: Re* [PATCH 2/2] check-ignore.c: fix segfault with '.' argument from repo root

2013-02-19 Thread Adam Spiers
On Tue, Feb 19, 2013 at 11:56:44AM -0800, Junio C Hamano wrote: > Adam Spiers writes: > > > Fair enough. I'll reply to this with a new version.[0] > > > > [0] I wish there was a clean way to include the new version inline, > > but as I've noted before, there doesn't seem to be: > > > > h

Re* [PATCH 2/2] check-ignore.c: fix segfault with '.' argument from repo root

2013-02-19 Thread Junio C Hamano
Adam Spiers writes: > Fair enough. I'll reply to this with a new version.[0] > > [0] I wish there was a clean way to include the new version inline, > but as I've noted before, there doesn't seem to be: > > http://article.gmane.org/gmane.comp.version-control.git/146110 I find it easier

Re: [PATCH 2/2] check-ignore.c: fix segfault with '.' argument from repo root

2013-02-19 Thread Adam Spiers
On Tue, Feb 19, 2013 at 5:54 PM, Junio C Hamano wrote: > Adam Spiers writes: > >> Fix a corner case where check-ignore would segfault when run with the >> '.' argument from the top level of a repository, due to prefix_path() >> converting '.' into the empty string. It doesn't make much sense to

Re: [PATCH 2/2] check-ignore.c: fix segfault with '.' argument from repo root

2013-02-19 Thread Junio C Hamano
Adam Spiers writes: > Fix a corner case where check-ignore would segfault when run with the > '.' argument from the top level of a repository, due to prefix_path() > converting '.' into the empty string. It doesn't make much sense to > call check-ignore from the top level with '.' as a parameter

[PATCH 2/2] check-ignore.c: fix segfault with '.' argument from repo root

2013-02-19 Thread Adam Spiers
Fix a corner case where check-ignore would segfault when run with the '.' argument from the top level of a repository, due to prefix_path() converting '.' into the empty string. It doesn't make much sense to call check-ignore from the top level with '.' as a parameter, since the top-level director