Re: [PATCH 2/2] bisect--helper: `bisect_voc` shell function in C

2016-05-23 Thread Johannes Schindelin
Hi Pranit, On Fri, 20 May 2016, Pranit Bauva wrote: > On Mon, May 16, 2016 at 12:10 PM, Johannes Schindelin > wrote: > > > > On Sat, 14 May 2016, Pranit Bauva wrote: > > > >> Reimplement the `bisect_voc` shell function in C. This is a too small > >> function to be called as a subcommand though t

Re: [PATCH 2/2] bisect--helper: `bisect_voc` shell function in C

2016-05-22 Thread Pranit Bauva
Hey Matthieu, Sorry for the late reply. Somehow your email didn't receive my mailbox. I got to see this mail when I was going through the gmane archives. Matthieu Moy grenoble-inp.fr> writes: Pranit Bauva gmail.com> writes: >> +int bisect_voc(const char *term) >> +{ >> + if (!strcmp(term, "ba

Re: [PATCH 2/2] bisect--helper: `bisect_voc` shell function in C

2016-05-20 Thread Pranit Bauva
Hey Johannes, On Mon, May 16, 2016 at 12:10 PM, Johannes Schindelin wrote: > Hi Pranit, > > On Sat, 14 May 2016, Pranit Bauva wrote: > >> Reimplement the `bisect_voc` shell function in C. This is a too small >> function to be called as a subcommand though the working of this >> function has been

Re: [PATCH 2/2] bisect--helper: `bisect_voc` shell function in C

2016-05-16 Thread Matthieu Moy
Pranit Bauva writes: > +int bisect_voc(const char *term) > +{ > + if (!strcmp(term, "bad")) > + printf("bad|new\n"); > + if (!strcmp(term, "good")) > + printf("good|old\n"); If you meant to use this as a helper command, then the implementation is right, but you're

Re: [PATCH 2/2] bisect--helper: `bisect_voc` shell function in C

2016-05-15 Thread Johannes Schindelin
Hi Pranit, On Sat, 14 May 2016, Pranit Bauva wrote: > Reimplement the `bisect_voc` shell function in C. This is a too small > function to be called as a subcommand though the working of this > function has been tested by calling it as a subcommand. This leaves me puzzled as to what this patch is

Re: [PATCH 2/2] bisect--helper: `bisect_voc` shell function in C

2016-05-13 Thread Pranit Bauva
On Sat, May 14, 2016 at 1:32 AM, Pranit Bauva wrote: > Reimplement the `bisect_voc` shell function in C. This is a too small > function to be called as a subcommand though the working of this > function has been tested by calling it as a subcommand. > > Mentored-by: Lars Schneider > Mentored-by:

[PATCH 2/2] bisect--helper: `bisect_voc` shell function in C

2016-05-13 Thread Pranit Bauva
Reimplement the `bisect_voc` shell function in C. This is a too small function to be called as a subcommand though the working of this function has been tested by calling it as a subcommand. Mentored-by: Lars Schneider Mentored-by: Pranit Bauva Signed-off-by: Pranit Bauva --- The PR for testin