Re: [PATCH 2/2] Speed up is_git_command() by checking early for internal commands

2014-01-02 Thread Sebastian Schuberth
On 02.01.2014 09:51, Christian Couder wrote: diff --git a/builtin/help.c b/builtin/help.c index b6fc15e..1f0261e 100644 --- a/builtin/help.c +++ b/builtin/help.c @@ -284,10 +284,15 @@ static int git_help_config(const char *var, const char *value, void *cb) return git_default_config(var

Re: [PATCH 2/2] Speed up is_git_command() by checking early for internal commands

2014-01-02 Thread Christian Couder
On Mon, Dec 30, 2013 at 10:07 PM, Sebastian Schuberth wrote: > Since 2dce956 is_git_command() was a bit slow as it does file I/O in the > call to list_commands_in_dir(). Avoid the file I/O by adding an early > check for internal commands. > > Signed-off-by: Sebastian Schuberth > --- > builtin/he

[PATCH 2/2] Speed up is_git_command() by checking early for internal commands

2013-12-30 Thread Sebastian Schuberth
Since 2dce956 is_git_command() was a bit slow as it does file I/O in the call to list_commands_in_dir(). Avoid the file I/O by adding an early check for internal commands. Signed-off-by: Sebastian Schuberth --- builtin/help.c | 5 ++ git.c | 242 ++-