Re: [PATCH 2/2] Move unsigned long option parsing out of pack-objects.c

2015-06-22 Thread Junio C Hamano
Charles Bailey writes: > From: Charles Bailey > > The unsigned long option parsing (including 'k'/'m'/'g' suffix parsing) > is more widely applicable. Add support for OPT_MAGNITUDE to > parse-options.h and change pack-objects.c use this support. > > The error behavior on parse errors follows tha

Re: [PATCH 2/2] Move unsigned long option parsing out of pack-objects.c

2015-06-22 Thread Junio C Hamano
Charles Bailey writes: > On Sun, Jun 21, 2015 at 07:25:44PM +0100, Charles Bailey wrote: >> From: Charles Bailey >> >> diff --git a/parse-options.c b/parse-options.c >> index 80106c0..101b649 100644 >> --- a/parse-options.c >> +++ b/parse-options.c >> @@ -180,6 +180,23 @@ static int get_value(s

Re: [PATCH 2/2] Move unsigned long option parsing out of pack-objects.c

2015-06-21 Thread Charles Bailey
On Sun, Jun 21, 2015 at 07:25:44PM +0100, Charles Bailey wrote: > From: Charles Bailey > > diff --git a/parse-options.c b/parse-options.c > index 80106c0..101b649 100644 > --- a/parse-options.c > +++ b/parse-options.c > @@ -180,6 +180,23 @@ static int get_value(struct parse_opt_ctx_t *p, >

[PATCH 2/2] Move unsigned long option parsing out of pack-objects.c

2015-06-21 Thread Charles Bailey
From: Charles Bailey The unsigned long option parsing (including 'k'/'m'/'g' suffix parsing) is more widely applicable. Add support for OPT_MAGNITUDE to parse-options.h and change pack-objects.c use this support. The error behavior on parse errors follows that of OPT_INTEGER. The name of the opt