Re: [PATCH 2/1] repack: warn if bitmaps are explicitly enabled with keep files

Jeff King writes: > On Wed, Jul 03, 2019 at 11:10:22AM -0700, Junio C Hamano wrote: > >> > Or perhaps we could differentiate our temporary locks from "real" .keep >> > files by looking at the content; I think our locks always say something >> > like "(receive|receive)-pack \d+ on .*", and it woul

Re: [PATCH 2/1] repack: warn if bitmaps are explicitly enabled with keep files

On Wed, Jul 03, 2019 at 11:37:52AM -0700, Junio C Hamano wrote: > In the meantime, this is about patch 2/1; the underlying "when .keep > is there, disable bitmaps" is probably good to go, still. > > -- >8 -- > From: Eric Wong > Date: Sat, 29 Jun 2019 19:13:59 + > Subject: [PATCH] repack: dis

Re: [PATCH 2/1] repack: warn if bitmaps are explicitly enabled with keep files

On Wed, Jul 03, 2019 at 11:10:22AM -0700, Junio C Hamano wrote: > > Or perhaps we could differentiate our temporary locks from "real" .keep > > files by looking at the content; I think our locks always say something > > like "(receive|receive)-pack \d+ on .*", and it wouldn't be too onerous > > to

Re: [PATCH 2/1] repack: warn if bitmaps are explicitly enabled with keep files

Junio C Hamano writes: > Jeff King writes: > >> >> A much more robust solution would be to stop conflating user-provided >> permanent .keep files with temporary locks. I think that was a mistaken >> design added many years ago. We probably could introduce a different >> filename for the temporar

Re: [PATCH 2/1] repack: warn if bitmaps are explicitly enabled with keep files

Jeff King writes: > > A much more robust solution would be to stop conflating user-provided > permanent .keep files with temporary locks. I think that was a mistaken > design added many years ago. We probably could introduce a different > filename for the temporary locks (though I am not entirely

Re: [PATCH 2/1] repack: warn if bitmaps are explicitly enabled with keep files

On Mon, Jul 01, 2019 at 11:15:38AM -0700, Junio C Hamano wrote: > >> Maybe that's tricky with the gc.log functionality, but I think we should > >> at least document this before the next guy shows up with "sometimes my > >> .bitmap files aren't generated...". > > > > I'm not sure if the warning sho

Re: [PATCH 2/1] repack: warn if bitmaps are explicitly enabled with keep files

Eric Wong writes: > Ævar Arnfjörð Bjarmason wrote: >> I have the feedback I posted before this patch in >> https://public-inbox.org/git/874l4f8h4c@evledraar.gmail.com/ >> >> In particular "b" there since "a" is clearly more work. I.e. shouldn't >> we at least in interactive mode on a "gc" p

[PATCH 2/1] repack: warn if bitmaps are explicitly enabled with keep files

Ævar Arnfjörð Bjarmason wrote: > I have the feedback I posted before this patch in > https://public-inbox.org/git/874l4f8h4c@evledraar.gmail.com/ > > In particular "b" there since "a" is clearly more work. I.e. shouldn't > we at least in interactive mode on a "gc" print something about skippi