Re: [PATCH 17/26] diff.c: convert show_stats to use emit_diff_symbol

2017-06-21 Thread Stefan Beller
>> case DIFF_SYMBOL_SUBMODULE_PIPETHROUGH: >> emit_line(o, "", "", line, len); >> break; >> + case DIFF_SYMBOL_STATS_SUMMARY_NO_FILES: >> + fprintf(o->file, " 0 files changed\n"); > > Why is this one a fprintf call instead of an emit_line call? I'm

Re: [PATCH 17/26] diff.c: convert show_stats to use emit_diff_symbol

2017-06-21 Thread Brandon Williams
On 06/19, Stefan Beller wrote: > We call print_stat_summary from builtin/apply, so we still > need the version with a file pointer, so introduce > print_stat_summary_0 that uses emit_string machinery and > keep print_stat_summary with the same arguments around. > > Signed-off-by: Stefan Beller >

[PATCH 17/26] diff.c: convert show_stats to use emit_diff_symbol

2017-06-19 Thread Stefan Beller
We call print_stat_summary from builtin/apply, so we still need the version with a file pointer, so introduce print_stat_summary_0 that uses emit_string machinery and keep print_stat_summary with the same arguments around. Signed-off-by: Stefan Beller --- diff.c | 118 +++