Re: [PATCH 17/17] fetch_refs(): simplify logic

2012-08-24 Thread Michael Haggerty
On 08/23/2012 11:07 AM, Jeff King wrote: > On Thu, Aug 23, 2012 at 10:10:42AM +0200, mhag...@alum.mit.edu wrote: > >> Subject: Re: [PATCH 17/17] fetch_refs(): simplify logic >> [...] >> static void filter_refs(struct ref **refs, int *nr_heads, char **heads) &g

Re: [PATCH 17/17] fetch_refs(): simplify logic

2012-08-23 Thread Jeff King
On Thu, Aug 23, 2012 at 10:10:42AM +0200, mhag...@alum.mit.edu wrote: > Subject: Re: [PATCH 17/17] fetch_refs(): simplify logic > [...] > static void filter_refs(struct ref **refs, int *nr_heads, char **heads) The subject should be "filter_refs", no? -Peff -- To unsubsc

[PATCH 17/17] fetch_refs(): simplify logic

2012-08-23 Thread mhagger
From: Michael Haggerty * Build linked list of return values as we go rather than recording them in a temporary array and linking them up later. * Handle ref in a single if...else statement in the main loop, to make it clear that each ref has exactly two possible destinies. Signed-off-by: Mi