Re: [PATCH 16/17] pathspec: small readability changes

2016-12-08 Thread Duy Nguyen
On Thu, Dec 8, 2016 at 6:27 AM, Brandon Williams wrote: >> On Wed, Dec 7, 2016 at 4:51 AM, Brandon Williams wrote: >> > @@ -362,8 +368,6 @@ static unsigned prefix_pathspec(struct pathspec_item >> > *item, >> > } else { >> > item->original = xstrdup(elt); >> > } >>

Re: [PATCH 16/17] pathspec: small readability changes

2016-12-07 Thread Brandon Williams
On 12/07, Duy Nguyen wrote: > On Wed, Dec 7, 2016 at 4:51 AM, Brandon Williams wrote: > > A few small changes to improve readability. This is done by grouping > > related > > assignments, adding blank lines, ensuring lines are <80 characters, etc. > > > > Signed-off-by: Brandon Williams > > ---

Re: [PATCH 16/17] pathspec: small readability changes

2016-12-07 Thread Brandon Williams
On 12/07, Duy Nguyen wrote: > On Wed, Dec 7, 2016 at 4:51 AM, Brandon Williams wrote: > > A few small changes to improve readability. This is done by grouping > > related > > assignments, adding blank lines, ensuring lines are <80 characters, etc. > > > > Signed-off-by: Brandon Williams > > ---

Re: [PATCH 16/17] pathspec: small readability changes

2016-12-07 Thread Junio C Hamano
Duy Nguyen writes: > On Wed, Dec 7, 2016 at 4:51 AM, Brandon Williams wrote: >> A few small changes to improve readability. This is done by grouping related >> assignments, adding blank lines, ensuring lines are <80 characters, etc. >> >> Signed-off-by: Brandon Williams >> --- >> pathspec.c |

Re: [PATCH 16/17] pathspec: small readability changes

2016-12-07 Thread Duy Nguyen
On Wed, Dec 7, 2016 at 4:51 AM, Brandon Williams wrote: > A few small changes to improve readability. This is done by grouping related > assignments, adding blank lines, ensuring lines are <80 characters, etc. > > Signed-off-by: Brandon Williams > --- > pathspec.c | 15 ++- > 1 file

Re: [PATCH 16/17] pathspec: small readability changes

2016-12-07 Thread Duy Nguyen
On Wed, Dec 7, 2016 at 4:51 AM, Brandon Williams wrote: > A few small changes to improve readability. This is done by grouping related > assignments, adding blank lines, ensuring lines are <80 characters, etc. > > Signed-off-by: Brandon Williams > --- > pathspec.c | 15 ++- > 1 file

Re: [PATCH 16/17] pathspec: small readability changes

2016-12-06 Thread Stefan Beller
On Tue, Dec 6, 2016 at 1:51 PM, Brandon Williams wrote: > A few small changes to improve readability. This is done by grouping related > assignments, adding blank lines, ensuring lines are <80 characters, etc. The 'etc' sounds a bit sloppy in the commit message. Maybe s/etc/and adding proper com

[PATCH 16/17] pathspec: small readability changes

2016-12-06 Thread Brandon Williams
A few small changes to improve readability. This is done by grouping related assignments, adding blank lines, ensuring lines are <80 characters, etc. Signed-off-by: Brandon Williams --- pathspec.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/pathspec.c b/