Re: [PATCH 14/16] fetch-pack: refactor parsing in get_ack

2014-06-19 Thread Eric Sunshine
On Wed, Jun 18, 2014 at 3:56 PM, Jeff King wrote: > There are several uses of the magic number "line+45" when > parsing ACK lines from the server, and it's rather unclear > why 45 is the correct number. We can make this more clear by > keeping a running pointer as we parse, using skip_prefix to >

[PATCH 14/16] fetch-pack: refactor parsing in get_ack

2014-06-18 Thread Jeff King
There are several uses of the magic number "line+45" when parsing ACK lines from the server, and it's rather unclear why 45 is the correct number. We can make this more clear by keeping a running pointer as we parse, using skip_prefix to jump past the first "ACK ", then adding 40 to jump past get_s