Re: [PATCH 13/18] fill_sha1_file: write "boring" characters

2016-10-05 Thread Junio C Hamano
Jacob Keller writes: >> The cost of fill function having to do the same thing repeatedly is >> negligible, so I am OK with the result, but for fairness, this was >> not "make the callers do this extra thing", but was "the caller can >> prepare these unchanging parts just once, and the fill functi

Re: [PATCH 13/18] fill_sha1_file: write "boring" characters

2016-10-04 Thread Jacob Keller
On Tue, Oct 4, 2016 at 2:46 PM, Junio C Hamano wrote: > Jacob Keller writes: > >> On Mon, Oct 3, 2016 at 1:35 PM, Jeff King wrote: >>> This function forms a sha1 as "xx/...", but skips over >>> the slot for the slash rather than writing it, leaving it to >>> the caller to do so. It also does

Re: [PATCH 13/18] fill_sha1_file: write "boring" characters

2016-10-04 Thread Jeff King
On Tue, Oct 04, 2016 at 02:46:44PM -0700, Junio C Hamano wrote: > Jacob Keller writes: > > > On Mon, Oct 3, 2016 at 1:35 PM, Jeff King wrote: > >> This function forms a sha1 as "xx/...", but skips over > >> the slot for the slash rather than writing it, leaving it to > >> the caller to do s

Re: [PATCH 13/18] fill_sha1_file: write "boring" characters

2016-10-04 Thread Junio C Hamano
Jacob Keller writes: > On Mon, Oct 3, 2016 at 1:35 PM, Jeff King wrote: >> This function forms a sha1 as "xx/...", but skips over >> the slot for the slash rather than writing it, leaving it to >> the caller to do so. It also does not bother to put in a >> trailing NUL, even though every cal

Re: [PATCH 13/18] fill_sha1_file: write "boring" characters

2016-10-03 Thread Jacob Keller
On Mon, Oct 3, 2016 at 1:35 PM, Jeff King wrote: > This function forms a sha1 as "xx/...", but skips over > the slot for the slash rather than writing it, leaving it to > the caller to do so. It also does not bother to put in a > trailing NUL, even though every caller would want it (we're > fo

[PATCH 13/18] fill_sha1_file: write "boring" characters

2016-10-03 Thread Jeff King
This function forms a sha1 as "xx/...", but skips over the slot for the slash rather than writing it, leaving it to the caller to do so. It also does not bother to put in a trailing NUL, even though every caller would want it (we're forming a path which by definition is not a directory, so the