Re: [PATCH 12/21] patch-ids.c: remove implicit dependency on the_index

2018-09-10 Thread Stefan Beller
On Sun, Sep 9, 2018 at 1:02 AM Duy Nguyen wrote: > > On Tue, Sep 4, 2018 at 9:54 PM Stefan Beller wrote: > > > > On Mon, Sep 3, 2018 at 11:03 AM Duy Nguyen wrote: > > > > > > On Mon, Aug 27, 2018 at 9:13 PM Stefan Beller wrote: > > > > > > > > > -int init_patch_ids(struct patch_ids *ids) > > >

Re: [PATCH 12/21] patch-ids.c: remove implicit dependency on the_index

2018-09-09 Thread Duy Nguyen
On Tue, Sep 4, 2018 at 9:54 PM Stefan Beller wrote: > > On Mon, Sep 3, 2018 at 11:03 AM Duy Nguyen wrote: > > > > On Mon, Aug 27, 2018 at 9:13 PM Stefan Beller wrote: > > > > > > > -int init_patch_ids(struct patch_ids *ids) > > > > +int init_patch_ids(struct patch_ids *ids, struct repository *re

Re: [PATCH 12/21] patch-ids.c: remove implicit dependency on the_index

2018-09-04 Thread Stefan Beller
On Mon, Sep 3, 2018 at 11:03 AM Duy Nguyen wrote: > > On Mon, Aug 27, 2018 at 9:13 PM Stefan Beller wrote: > > > > > -int init_patch_ids(struct patch_ids *ids) > > > +int init_patch_ids(struct patch_ids *ids, struct repository *repo) > > > { > > > memset(ids, 0, sizeof(*ids)); > > > -

Re: [PATCH 12/21] patch-ids.c: remove implicit dependency on the_index

2018-09-03 Thread Duy Nguyen
On Mon, Aug 27, 2018 at 9:13 PM Stefan Beller wrote: > > > -int init_patch_ids(struct patch_ids *ids) > > +int init_patch_ids(struct patch_ids *ids, struct repository *repo) > > { > > memset(ids, 0, sizeof(*ids)); > > - diff_setup(&ids->diffopts, the_repository); > > + diff_se

Re: [PATCH 12/21] patch-ids.c: remove implicit dependency on the_index

2018-08-27 Thread Stefan Beller
> -int init_patch_ids(struct patch_ids *ids) > +int init_patch_ids(struct patch_ids *ids, struct repository *repo) > { > memset(ids, 0, sizeof(*ids)); > - diff_setup(&ids->diffopts, the_repository); > + diff_setup(&ids->diffopts, repo); Just realized when looking at this diff,

[PATCH 12/21] patch-ids.c: remove implicit dependency on the_index

2018-08-26 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- builtin/log.c | 2 +- patch-ids.c | 4 ++-- patch-ids.h | 3 ++- revision.c| 2 +- 4 files changed, 6 insertions(+), 5 deletions(-) diff --git a/builtin/log.c b/builtin/log.c index 33084102e0..2910122d90 100644 --- a/builtin/log.c +++ b/builtin/log