Re: [PATCH 12/16] refs: always handle non-normal refs in files backend

2016-01-06 Thread David Turner
On Wed, 2015-12-23 at 09:02 +0100, Michael Haggerty wrote: > I very much like the idea of introducing special handling for > symbolic > reference updates within a transaction. In fact, I think I would go > even > farther: > > Let's take the example of an update to HEAD, which currently points > at

Re: [PATCH 12/16] refs: always handle non-normal refs in files backend

2016-01-05 Thread David Turner
On Wed, 2015-12-23 at 09:02 +0100, Michael Haggerty wrote: > + * We move other non-normal ref updates with into a specially > > -created > > + * files-backend transaction > > + */ > > Extra word? s/with//? Fixed, thanks. > > + add_update_obj(files_transaction, update); > > +

Re: [PATCH 12/16] refs: always handle non-normal refs in files backend

2015-12-23 Thread Michael Haggerty
On 12/03/2015 01:35 AM, David Turner wrote: > Always handle non-normal (per-worktree or pseudo) refs in the files > backend instead of alternate backends. > > Sometimes a ref transaction will update both a per-worktree ref and a > normal ref. For instance, an ordinary commit might update > refs/h

[PATCH 12/16] refs: always handle non-normal refs in files backend

2015-12-02 Thread David Turner
Always handle non-normal (per-worktree or pseudo) refs in the files backend instead of alternate backends. Sometimes a ref transaction will update both a per-worktree ref and a normal ref. For instance, an ordinary commit might update refs/heads/master and HEAD (or at least HEAD's reflog). We ha