Re: [PATCH 12/15] sequencer: lib'ify save_opts()

2016-08-29 Thread Johannes Schindelin
Hi Junio, On Fri, 26 Aug 2016, Junio C Hamano wrote: > Johannes Schindelin writes: > > > static int pick_commits(struct commit_list *todo_list, struct replay_opts > > *opts) > > @@ -1128,9 +1130,9 @@ int sequencer_pick_revisions(struct replay_opts *opts) > > return -1; > > if

Re: [PATCH 12/15] sequencer: lib'ify save_opts()

2016-08-26 Thread Junio C Hamano
Johannes Schindelin writes: > static int pick_commits(struct commit_list *todo_list, struct replay_opts > *opts) > @@ -1128,9 +1130,9 @@ int sequencer_pick_revisions(struct replay_opts *opts) > return -1; > if (get_sha1("HEAD", sha1) && (opts->action == REPLAY_REVERT)) >

[PATCH 12/15] sequencer: lib'ify save_opts()

2016-08-23 Thread Johannes Schindelin
To be truly useful, the sequencer should never die() but always return an error. Signed-off-by: Johannes Schindelin --- sequencer.c | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/sequencer.c b/sequencer.c index 17f2c8b..bac32ea 100644 --- a/seque