Re: [PATCH 11/19] tree-diff: simplify tree_entry_pathcmp

2014-03-25 Thread Kirill Smelkov
On Mon, Mar 24, 2014 at 02:25:04PM -0700, Junio C Hamano wrote: > Kirill Smelkov writes: > > > Since an earlier "Finally switch over tree descriptors to contain a > > pre-parsed entry", we can safely access all tree_desc->entry fields > > directly instead of first "extracting" them through > > tr

Re: [PATCH 11/19] tree-diff: simplify tree_entry_pathcmp

2014-03-24 Thread Junio C Hamano
Kirill Smelkov writes: > Since an earlier "Finally switch over tree descriptors to contain a > pre-parsed entry", we can safely access all tree_desc->entry fields > directly instead of first "extracting" them through > tree_entry_extract. > > Use it. The code generated stays the same - only it no

[PATCH 11/19] tree-diff: simplify tree_entry_pathcmp

2014-02-24 Thread Kirill Smelkov
Since an earlier "Finally switch over tree descriptors to contain a pre-parsed entry", we can safely access all tree_desc->entry fields directly instead of first "extracting" them through tree_entry_extract. Use it. The code generated stays the same - only it now visually looks cleaner. Signed-of