Re: [PATCH 11/15] diff: ignore submodules excluded by groups

2016-05-06 Thread Junio C Hamano
Stefan Beller writes: >> Further suppose that the user needs to view a submodule outside the >> default group temporarily (imagine: for a day or two), while >> carrying out some specific task. Perhaps she is working on the >> documentation submodule, which is her primary task hence her >> config

Re: [PATCH 11/15] diff: ignore submodules excluded by groups

2016-05-06 Thread Stefan Beller
On Thu, May 5, 2016 at 11:08 PM, Junio C Hamano wrote: > Junio C Hamano writes: > >> The set of submodules you "init" to the working tree are the ones >> that are interesting to you. So once the tree is populated, you do >> not ever have to look at the "defaultGroup" configuration. You just >>

Re: [PATCH 11/15] diff: ignore submodules excluded by groups

2016-05-05 Thread Junio C Hamano
Junio C Hamano writes: > The set of submodules you "init" to the working tree are the ones > that are interesting to you. So once the tree is populated, you do > not ever have to look at the "defaultGroup" configuration. You just > need to look at the working tree. > ... I forgot to prefix the

Re: [PATCH 11/15] diff: ignore submodules excluded by groups

2016-05-05 Thread Junio C Hamano
Stefan Beller writes: > I am aware that other operations such as a build system would be glad to > have the contents of the submodules there. But those would not use a > restrictive default group? The set of submodules you "init" to the working tree are the ones that are interesting to you. So

Re: [PATCH 11/15] diff: ignore submodules excluded by groups

2016-05-05 Thread Stefan Beller
On Thu, May 5, 2016 at 3:20 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> The first option is giving nothing: >> >> git config submodule.defaultGroup "*SomeLabel" >> git -C submodule-not-labeled reset --hard HEAD^ >> git status >> # all good, no report about submodul

Re: [PATCH 11/15] diff: ignore submodules excluded by groups

2016-05-05 Thread Junio C Hamano
Stefan Beller writes: > The first option is giving nothing: > > git config submodule.defaultGroup "*SomeLabel" > git -C submodule-not-labeled reset --hard HEAD^ > git status > # all good, no report about submodule-not-labeled > # because it is not in the default group. >

Re: [PATCH 11/15] diff: ignore submodules excluded by groups

2016-05-05 Thread Stefan Beller
On Thu, May 5, 2016 at 1:19 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> Any thoughts on my thoughts below? >> >>> So here is a thought experiment: >>> >>> # get all submodules into the work tree >>> git submodule update --recursive --init >>> >>> # The selected default grou

Re: [PATCH 11/15] diff: ignore submodules excluded by groups

2016-05-05 Thread Junio C Hamano
Stefan Beller writes: > Any thoughts on my thoughts below? > >> So here is a thought experiment: >> >> # get all submodules into the work tree >> git submodule update --recursive --init >> >> # The selected default group will not include all submodules >> git config submodule.defa

Re: [PATCH 11/15] diff: ignore submodules excluded by groups

2016-05-05 Thread Stefan Beller
Any thoughts on my thoughts below? On Fri, Apr 29, 2016 at 12:17 PM, Stefan Beller wrote: > On Fri, Apr 29, 2016 at 11:37 AM, Junio C Hamano wrote: >> Stefan Beller writes: >> >>> We do not need to do anything special to initialize the `submodule_groups` >>> pointer as the diff options setup wi

Re: [PATCH 11/15] diff: ignore submodules excluded by groups

2016-04-29 Thread Stefan Beller
On Fri, Apr 29, 2016 at 11:37 AM, Junio C Hamano wrote: > Stefan Beller writes: > >> We do not need to do anything special to initialize the `submodule_groups` >> pointer as the diff options setup will fill in 0 by default. >> >> Signed-off-by: Stefan Beller >> --- >> diff.c | 3 +++ >> diff.h

Re: [PATCH 11/15] diff: ignore submodules excluded by groups

2016-04-29 Thread Junio C Hamano
Stefan Beller writes: > We do not need to do anything special to initialize the `submodule_groups` > pointer as the diff options setup will fill in 0 by default. > > Signed-off-by: Stefan Beller > --- > diff.c | 3 +++ > diff.h | 1 + > 2 files changed, 4 insertions(+) Isn't this going in the

[PATCH 11/15] diff: ignore submodules excluded by groups

2016-04-26 Thread Stefan Beller
We do not need to do anything special to initialize the `submodule_groups` pointer as the diff options setup will fill in 0 by default. Signed-off-by: Stefan Beller --- diff.c | 3 +++ diff.h | 1 + 2 files changed, 4 insertions(+) diff --git a/diff.c b/diff.c index 059123c..5808d8a 100644 ---