Re: [PATCH 10/44] object-store: move packed_git and packed_git_mru to object store

2018-03-23 Thread Brandon Williams
On 03/23, Duy Nguyen wrote: > On Fri, Mar 23, 2018 at 6:03 PM, Duy Nguyen wrote: > > On Wed, Mar 21, 2018 at 11:18 PM, Brandon Williams > > wrote: > >> You're marking packed_git > >> as "private"...well C has no notion of private vs public fields in a > >> struct so it might be difficult to keep

Re: [PATCH 10/44] object-store: move packed_git and packed_git_mru to object store

2018-03-23 Thread Duy Nguyen
On Fri, Mar 23, 2018 at 6:03 PM, Duy Nguyen wrote: > On Wed, Mar 21, 2018 at 11:18 PM, Brandon Williams wrote: >> You're marking packed_git >> as "private"...well C has no notion of private vs public fields in a >> struct so it might be difficult to keep that convention, it also took me >> a seco

Re: [PATCH 10/44] object-store: move packed_git and packed_git_mru to object store

2018-03-23 Thread Duy Nguyen
On Wed, Mar 21, 2018 at 11:18 PM, Brandon Williams wrote: > You're marking packed_git > as "private"...well C has no notion of private vs public fields in a > struct so it might be difficult to keep that convention, it also took me > a second to realize that it was only in the scope of packfile.c

Re: [PATCH 10/44] object-store: move packed_git and packed_git_mru to object store

2018-03-23 Thread Duy Nguyen
On Mon, Mar 19, 2018 at 8:39 PM, Jonathan Tan wrote: > On Sat, 3 Mar 2018 18:36:03 +0700 > Nguyễn Thái Ngọc Duy wrote: > >> From: Stefan Beller >> >> In a process with multiple repositories open, packfile accessors >> should be associated to a single repository and not shared globally. >> Move

Re: [PATCH 10/44] object-store: move packed_git and packed_git_mru to object store

2018-03-21 Thread Brandon Williams
On 03/03, Nguyễn Thái Ngọc Duy wrote: > From: Stefan Beller > > In a process with multiple repositories open, packfile accessors > should be associated to a single repository and not shared globally. > Move packed_git and packed_git_mru into the_repository and adjust > callers to reflect this. >

Re: [PATCH 10/44] object-store: move packed_git and packed_git_mru to object store

2018-03-19 Thread Jonathan Tan
On Sat, 3 Mar 2018 18:36:03 +0700 Nguyễn Thái Ngọc Duy wrote: > From: Stefan Beller > > In a process with multiple repositories open, packfile accessors > should be associated to a single repository and not shared globally. > Move packed_git and packed_git_mru into the_repository and adjust >

[PATCH 10/44] object-store: move packed_git and packed_git_mru to object store

2018-03-03 Thread Nguyễn Thái Ngọc Duy
From: Stefan Beller In a process with multiple repositories open, packfile accessors should be associated to a single repository and not shared globally. Move packed_git and packed_git_mru into the_repository and adjust callers to reflect this. [nd: while at there, wrap access to these two field