RE: [PATCH 1/9] git-compat-util.h: Add missing semicolon after struct itimerval

2014-09-02 Thread Keller, Jacob E
ect: Re: [PATCH 1/9] git-compat-util.h: Add missing semicolon after > struct itimerval > > On 08/29/2014 09:07 PM, Junio C Hamano wrote: > > Jonas 'Sortie' Termansen writes: > > That is easy to fix, isn't it? > > > > Where you said "If you have ti

Re: [PATCH 1/9] git-compat-util.h: Add missing semicolon after struct itimerval

2014-08-29 Thread Jonas 'Sortie' Termansen
On 08/29/2014 09:07 PM, Junio C Hamano wrote: > Jonas 'Sortie' Termansen writes: > That is easy to fix, isn't it? > > Where you said "If you have timer_settimer(), set this makefile > variable", you start the sentence with "If you have a working > timer_settimer()" instead. That's mostly right.

Re: [PATCH 1/9] git-compat-util.h: Add missing semicolon after struct itimerval

2014-08-29 Thread Junio C Hamano
Jonas 'Sortie' Termansen writes: > Jake's modified patch set breaks the case where timer_settimer exists and > is broken. As far as I know, that's only OpenBSD among the noticeable free > software world, but could be more systems, perhaps in the future. That is easy to fix, isn't it? Where you

Re: [PATCH 1/9] git-compat-util.h: Add missing semicolon after struct itimerval

2014-08-29 Thread Jonas 'Sortie' Termansen
Hi, Thanks for the interest. :) There's a whole lot of emails being sent. I'll make a nice V2 shortly that takes your feedback into consideration. :) But first let's discuss. I think we should define the intended criteria. I expect to find these systems out there: * No setitimer and no timer_s

Re: [PATCH 1/9] git-compat-util.h: Add missing semicolon after struct itimerval

2014-08-29 Thread Keller, Jacob E
On Fri, 2014-08-29 at 09:42 -0700, Jacob Keller wrote: > From: Jonas 'Sortie' Termansen > > This hasn't been a problem in practice as almost all systems have the > setitimer() API (or it is provided by git in the case of mingw). This code > wasn't used in any default circumstances, as the build s

[PATCH 1/9] git-compat-util.h: Add missing semicolon after struct itimerval

2014-08-29 Thread Jacob Keller
From: Jonas 'Sortie' Termansen This hasn't been a problem in practice as almost all systems have the setitimer() API (or it is provided by git in the case of mingw). This code wasn't used in any default circumstances, as the build system never sets NO_STRUCT_ITIMERVAL - this breakage only occured

[PATCH 1/9] git-compat-util.h: Add missing semicolon after struct itimerval

2014-08-27 Thread Jonas 'Sortie' Termansen
This hasn't been a problem in practice as almost all systems have the setitimer() API (or it is provided by git in the case of mingw). This code wasn't used in any default circumstances, as the build system never sets NO_STRUCT_ITIMERVAL - this breakage only occured if the user asked for it. We re