[PATCH 1/7] submodule.c: use argv_array in is_submodule_modified

struct argv_array is easier to use and maintain. Signed-off-by: Stefan Beller Reviewed-by: Jonathan Nieder --- submodule.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/submodule.c b/submodule.c index 3200b7bb2b..2c667ac95a 100644 --- a/submodule.c +++ b/submodu

Re: [PATCH 1/7] submodule.c: use argv_array in is_submodule_modified

Stefan Beller wrote: > struct argv_array is easier to use and maintain Missing '.' at end of sentence. > Signed-off-by: Stefan Beller > --- > submodule.c | 10 ++ > 1 file changed, 2 insertions(+), 8 deletions(-) With or without that tweak, I still like this as much as last time. :) R

[PATCH 1/7] submodule.c: use argv_array in is_submodule_modified

struct argv_array is easier to use and maintain Signed-off-by: Stefan Beller --- submodule.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/submodule.c b/submodule.c index 3200b7bb2b..2c667ac95a 100644 --- a/submodule.c +++ b/submodule.c @@ -1043,12 +1043,6 @@ uns

Re: [PATCH 1/7] submodule.c: use argv_array in is_submodule_modified

Stefan Beller wrote: > struct argv_array is easier to use and maintain Yes! [...] > submodule.c | 10 ++ > 1 file changed, 2 insertions(+), 8 deletions(-) I also like the diffstat. :) [...] > --- a/submodule.c > +++ b/submodule.c > @@ -1043,12 +1043,6 @@ unsigned is_submodule_modified

[PATCH 1/7] submodule.c: use argv_array in is_submodule_modified

struct argv_array is easier to use and maintain Signed-off-by: Stefan Beller --- submodule.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/submodule.c b/submodule.c index 3200b7bb2b..2c667ac95a 100644 --- a/submodule.c +++ b/submodule.c @@ -1043,12 +1043,6 @@ uns