Re: [PATCH 1/7] for_each_*_object: store flag definitions in a single location

2018-08-10 Thread Jeff King
On Fri, Aug 10, 2018 at 04:39:14PM -0700, Stefan Beller wrote: > > IMHO the whole for_each_*_object() interface should go in there (it even > > has packed_git defined there already!). I think I'd still just as soon > > do it on top of this series, but it might not be too bad to do as part > > of a

Re: [PATCH 1/7] for_each_*_object: store flag definitions in a single location

2018-08-10 Thread Stefan Beller
On Fri, Aug 10, 2018 at 4:33 PM Jeff King wrote: > > On Fri, Aug 10, 2018 at 07:31:33PM -0400, Jeff King wrote: > > > On Fri, Aug 10, 2018 at 04:27:25PM -0700, Stefan Beller wrote: > > > > > > cache.h| 13 - > > > > packfile.h | 8 ++-- > > > > 2 files changed, 14 insertions(

Re: [PATCH 1/7] for_each_*_object: store flag definitions in a single location

2018-08-10 Thread Jeff King
On Fri, Aug 10, 2018 at 07:31:33PM -0400, Jeff King wrote: > On Fri, Aug 10, 2018 at 04:27:25PM -0700, Stefan Beller wrote: > > > > cache.h| 13 - > > > packfile.h | 8 ++-- > > > 2 files changed, 14 insertions(+), 7 deletions(-) > > > > rubs me the wrong way. ;-) > > > >

Re: [PATCH 1/7] for_each_*_object: store flag definitions in a single location

2018-08-10 Thread Jeff King
On Fri, Aug 10, 2018 at 04:27:25PM -0700, Stefan Beller wrote: > > cache.h| 13 - > > packfile.h | 8 ++-- > > 2 files changed, 14 insertions(+), 7 deletions(-) > > rubs me the wrong way. ;-) > > cache.h is such a misnomer of a name, and a kitchen sink > of a file in the Gi

Re: [PATCH 1/7] for_each_*_object: store flag definitions in a single location

2018-08-10 Thread Stefan Beller
On Fri, Aug 10, 2018 at 4:09 PM Jeff King wrote: > > These flags were split between cache.h and packfile.h, > because some of the flags apply only to packs. However, they > share a single numeric namespace, since both are respected > for the packed variant. Let's make sure they're defined > togeth

[PATCH 1/7] for_each_*_object: store flag definitions in a single location

2018-08-10 Thread Jeff King
These flags were split between cache.h and packfile.h, because some of the flags apply only to packs. However, they share a single numeric namespace, since both are respected for the packed variant. Let's make sure they're defined together so that nobody accidentally adds a new flag in one location