Re: [PATCH 1/7] am: suppress error output from a conditional

2013-04-23 Thread Ramkumar Ramachandra
Junio C Hamano wrote: > Perhaps all of these "oops, 7/7 breaks this and that so let's work > them around" can be avoided if the series did not store the object > name of the stash that records the local changes as a plain text > file inside a $dotest/ directory, and instead used a dedicated ref > s

Re: [PATCH 1/7] am: suppress error output from a conditional

2013-04-23 Thread Junio C Hamano
Ramkumar Ramachandra writes: > Martin von Zweigbergk wrote: >> On Tue, Apr 23, 2013 at 7:01 AM, Ramkumar Ramachandra >> wrote: >>> When testing if the $dotest directory exists, and if $next is greater >>> than $last >> >> When can that happen? If one edits the todo? > > When git-rebase.sh create

Re: [PATCH 1/7] am: suppress error output from a conditional

2013-04-23 Thread Ramkumar Ramachandra
Martin von Zweigbergk wrote: > On Tue, Apr 23, 2013 at 7:01 AM, Ramkumar Ramachandra > wrote: >> When testing if the $dotest directory exists, and if $next is greater >> than $last > > When can that happen? If one edits the todo? When git-rebase.sh creates a $dotest directory with just an autosta

Re: [PATCH 1/7] am: suppress error output from a conditional

2013-04-23 Thread Junio C Hamano
Martin von Zweigbergk writes: > On Tue, Apr 23, 2013 at 7:01 AM, Ramkumar Ramachandra > wrote: >> When testing if the $dotest directory exists, and if $next is greater >> than $last > > When can that happen? If one edits the todo? More importantly, that condition is an unexpected error, which t

Re: [PATCH 1/7] am: suppress error output from a conditional

2013-04-23 Thread Martin von Zweigbergk
On Tue, Apr 23, 2013 at 7:01 AM, Ramkumar Ramachandra wrote: > When testing if the $dotest directory exists, and if $next is greater > than $last When can that happen? If one edits the todo? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vg

[PATCH 1/7] am: suppress error output from a conditional

2013-04-23 Thread Ramkumar Ramachandra
When testing if the $dotest directory exists, and if $next is greater than $last, the script currently executes `cat` on files that might not exist. So, suppress the error output from `cat`. Signed-off-by: Ramkumar Ramachandra --- git-am.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions