Re: [PATCH 1/6] test patch hunk editing with "commit -p -m"

2014-03-06 Thread Junio C Hamano
Eric Sunshine writes: >> +test_expect_failure 'edit hunk "commit -p -m message"' ' >> + echo e | env GIT_EDITOR="sed s/+line3\$/+line2/ -i" git commit -p -m >> commit2 file && >> + git diff HEAD^ HEAD >diff && >> + test_cmp expected diff >> +' > > If you ever add more tests, is

Re: [PATCH 1/6] test patch hunk editing with "commit -p -m"

2014-03-06 Thread Eric Sunshine
On Thu, Mar 6, 2014 at 9:50 AM, Benoit Pierre wrote: > Add (failing) test: with commit changing the environment to let hooks > now that no editor will be used (by setting GIT_EDITOR to ":"), the > "edit hunk" functionality does not work (no editor is launched and the > whole hunk is committed). >

[PATCH 1/6] test patch hunk editing with "commit -p -m"

2014-03-06 Thread Benoit Pierre
Add (failing) test: with commit changing the environment to let hooks now that no editor will be used (by setting GIT_EDITOR to ":"), the "edit hunk" functionality does not work (no editor is launched and the whole hunk is committed). Signed-off-by: Benoit Pierre --- t/t7513-commit_-p_-m_hunk_ed