Re: [PATCH 1/6] t4051: add test for comments preceding function lines

2017-11-20 Thread Junio C Hamano
René Scharfe writes: >> I am slightly in favor of than against the above reasoning, but it >> probably deserves to be recorded somewhere more readily accessible >> than the mailing list archive... >> >> perhaps? > > That's fine with me. As there seems to be no other reason for updating the seri

Re: [PATCH 1/6] t4051: add test for comments preceding function lines

2017-11-20 Thread René Scharfe
Am 20.11.2017 um 01:36 schrieb Junio C Hamano: > René Scharfe writes: > >> your suggested full-comment metric, i.e. more than nothing. But more >> importantly it's the actual comment payload. The leading "/*" line is >> included as a consequence of the employed heuristic, but a more >> refined

Re: [PATCH 1/6] t4051: add test for comments preceding function lines

2017-11-19 Thread Junio C Hamano
René Scharfe writes: > your suggested full-comment metric, i.e. more than nothing. But more > importantly it's the actual comment payload. The leading "/*" line is > included as a consequence of the employed heuristic, but a more > refined one might omit it as it doesn't actually contain any co

Re: [PATCH 1/6] t4051: add test for comments preceding function lines

2017-11-19 Thread René Scharfe
Am 19.11.2017 um 02:18 schrieb Eric Sunshine: > On Sat, Nov 18, 2017 at 1:04 PM, René Scharfe wrote: >> When showing function context it would be helpful to show comments >> immediately before declarations, as they are most likely relevant. Add >> a test for that. >> >> Signed-off-by: Rene Scharf

Re: [PATCH 1/6] t4051: add test for comments preceding function lines

2017-11-18 Thread Eric Sunshine
On Sat, Nov 18, 2017 at 1:04 PM, René Scharfe wrote: > When showing function context it would be helpful to show comments > immediately before declarations, as they are most likely relevant. Add > a test for that. > > Signed-off-by: Rene Scharfe > --- > diff --git a/t/t4051-diff-function-context

[PATCH 1/6] t4051: add test for comments preceding function lines

2017-11-18 Thread René Scharfe
When showing function context it would be helpful to show comments immediately before declarations, as they are most likely relevant. Add a test for that. Signed-off-by: Rene Scharfe --- t/t4051-diff-function-context.sh | 4 t/t4051/hello.c | 3 +++ 2 files changed, 7 inse