Re: [PATCH 1/5] refs.c: allow passing raw git_committer_info as email to _update_reflog

2014-07-28 Thread Eric Sunshine
On Mon, Jul 28, 2014 at 2:01 PM, Ronnie Sahlberg wrote: > On Fri, Jul 25, 2014 at 12:37 PM, Jonathan Nieder wrote: >> Ronnie Sahlberg wrote: >>> /* >>> * Append a reflog entry for refname. If the REFLOG_TRUNCATE flag is set >>> * this update will first truncate the reflog before writing the

Re: [PATCH 1/5] refs.c: allow passing raw git_committer_info as email to _update_reflog

2014-07-28 Thread Ronnie Sahlberg
On Fri, Jul 25, 2014 at 12:37 PM, Jonathan Nieder wrote: > Ronnie Sahlberg wrote: > >> Add a new flag REFLOG_EMAIL_IS_COMMITTER to _update_reflog to tell it >> that what we pass in as email is already the fully baked committer string >> we can use as-is. > > With and without the new flag, the 'ema

Re: [PATCH 1/5] refs.c: allow passing raw git_committer_info as email to _update_reflog

2014-07-25 Thread Jonathan Nieder
Ronnie Sahlberg wrote: > Add a new flag REFLOG_EMAIL_IS_COMMITTER to _update_reflog to tell it > that what we pass in as email is already the fully baked committer string > we can use as-is. With and without the new flag, the 'email' argument has two different meanings: * with the new flag, it

[PATCH 1/5] refs.c: allow passing raw git_committer_info as email to _update_reflog

2014-07-25 Thread Ronnie Sahlberg
In many places in the code we do not have access to the individual fields in the committer data. Instead we might only have access to prebaked data such as what is returned by git_committer_info() containing a string that consists of email, timestamp, zone etc. This makes it inconvenient to use tr